Skip to content

Update CES Tool: add snippetsConfig and serviceDirectoryConfig - #18580

Open
mp32154 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
mp32154:update-ces-tool-patch
Open

Update CES Tool: add snippetsConfig and serviceDirectoryConfig#18580
mp32154 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
mp32154:update-ces-tool-patch

Conversation

@mp32154

@mp32154 mp32154 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor
ces: added `snippets_config` field to `data_store_tool.modality_configs` and `service_directory_config` field to `python_function` in `google_ces_tool`

@modular-magician

modular-magician commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 53303ec:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 172 insertions(+)
google-beta provider View Diff 4 files changed, 172 insertions(+)
terraform-google-conversion View Diff 1 file changed, 66 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
75 73 0 2
Affected Service Packages
  • ces

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample_update
  • TestAccCESTool_cesToolPythonFunctionBasicExample_update

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccCESTool_cesToolPythonFunctionBasicExample_update
❌ Error · Log - TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample_update

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@mp32154 VCR tests complete for 53303ec!

@mp32154
mp32154 force-pushed the update-ces-tool-patch branch from 53303ec to ff893e3 Compare August 10, 2026 19:36
@modular-magician

modular-magician commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit ff893e3:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 173 insertions(+)
google-beta provider View Diff 4 files changed, 173 insertions(+)
terraform-google-conversion View Diff 1 file changed, 66 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
75 74 0 1
Affected Service Packages
  • ces

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample_update

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample_update

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@mp32154 VCR tests complete for ff893e3!

@mp32154
mp32154 force-pushed the update-ces-tool-patch branch from ff893e3 to 6205796 Compare August 11, 2026 13:57
@modular-magician

modular-magician commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6205796:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 173 insertions(+)
google-beta provider View Diff 4 files changed, 173 insertions(+)
terraform-google-conversion View Diff 1 file changed, 66 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
75 75 0 0
Affected Service Packages
  • ces

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@mp32154 VCR tests complete for 6205796!

@mp32154
mp32154 marked this pull request as ready for review August 11, 2026 14:15
@github-actions
github-actions Bot requested a review from BBBmau August 11, 2026 14:15
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

- name: enableSnippets
type: Boolean
description: Whether snippets are enabled.
send_empty_value: true

@BBBmau BBBmau Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason why this needs to be set? it seems like the default value is false making this unnecessary

https://docs.cloud.google.com/gemini-enterprise-cx/cx-agent-studio/reference/rest/v1/projects.locations.apps.tools#Tool.DataStoreTool.SnippetsConfig

@mp32154 mp32154 Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The acceptance test fails without send_empty_value: true from previous runs: #18580 (comment)

=== CONT  TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample_update
    ces_tool_test.go:297: Step 3/4 error: After applying this test step, the non-refresh plan was not empty.
        stdout:
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        Terraform will perform the following actions:
          # google_ces_tool.ces_tool_data_store_tool_engine_source_basic will be updated in-place
          ~ resource "google_ces_tool" "ces_tool_data_store_tool_engine_source_basic" {
                id                = "projects/ci-test-project-188019/locations/us/apps/tf-test-app-idl0tyacvm0a/tools/tf_test_ces_tool_basic2l0tyacvm0a"
                name              = "tf_test_ces_tool_basic2l0tyacvm0a"
                # (17 unchanged attributes hidden)
              ~ data_store_tool {
                    name                      = "example-tool"
                    # (3 unchanged attributes hidden)
                  ~ modality_configs {
                        # (1 unchanged attribute hidden)
                      + snippets_config {
                          + enable_snippets = false
                        }
        
                        # (3 unchanged blocks hidden)
                    }
        
                    # (2 unchanged blocks hidden)
                }
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants