Update CES Tool: add snippetsConfig and serviceDirectoryConfig - #18580
Update CES Tool: add snippetsConfig and serviceDirectoryConfig#18580mp32154 wants to merge 1 commit into
Conversation
mp32154
commented
Aug 10, 2026
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 53303ec: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. |
53303ec to
ff893e3
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit ff893e3: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. |
ff893e3 to
6205796
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6205796: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
| - name: enableSnippets | ||
| type: Boolean | ||
| description: Whether snippets are enabled. | ||
| send_empty_value: true |
There was a problem hiding this comment.
is there a reason why this needs to be set? it seems like the default value is false making this unnecessary
There was a problem hiding this comment.
The acceptance test fails without send_empty_value: true from previous runs: #18580 (comment)
=== CONT TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample_update
ces_tool_test.go:297: Step 3/4 error: After applying this test step, the non-refresh plan was not empty.
stdout:
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# google_ces_tool.ces_tool_data_store_tool_engine_source_basic will be updated in-place
~ resource "google_ces_tool" "ces_tool_data_store_tool_engine_source_basic" {
id = "projects/ci-test-project-188019/locations/us/apps/tf-test-app-idl0tyacvm0a/tools/tf_test_ces_tool_basic2l0tyacvm0a"
name = "tf_test_ces_tool_basic2l0tyacvm0a"
# (17 unchanged attributes hidden)
~ data_store_tool {
name = "example-tool"
# (3 unchanged attributes hidden)
~ modality_configs {
# (1 unchanged attribute hidden)
+ snippets_config {
+ enable_snippets = false
}
# (3 unchanged blocks hidden)
}
# (2 unchanged blocks hidden)
}
}
Plan: 0 to add, 1 to change, 0 to destroy.