Add NetApp Trial Resource - #18576
Conversation
This reverts commit be09bd8.
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1b9d7d5: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportImportant Manual Verification Required VCR cannot automatically execute the following tests added in this PR. Please verify them manually: 🔴 TestAccNetappTrial_netappTrialExample Analytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the replaying VCR build log @anujagrawal-google, @SirGitsalot VCR tests complete for 1b9d7d5! |
Adds Terraform support for the Google Cloud NetApp Volumes (GCNV) Trial resource.
Implementation Details:
endTrialAPI endpoint requiresexitReasonand optionallyoptOutReasonsto be passed in the request body. Because these fields are not part of thesubscribeTrial(CREATE) request body, they are implemented as Terraform-only parameters (action_on_destroyandprovided_opt_out_reasons) using theurl_param_only: trueflag. This isolates them from theCREATErequest, and a custompre_deletehook maps them directly into theendTrialJSON payload duringterraform destroy.INACTIVEstate and returns200 OKrather than yielding standard404 Not Foundteardown responses. A customtest_check_destroytemplate has been added to safely validate theINACTIVEREST response during testing.CREATE,READ(import), andDELETElifecycle (including the custom parameter injection and theINACTIVEdestroy validation) has been manually verified end-to-end against the Google Cloud Staging sandbox.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.