Skip to content

Fix type piracies in minimum, maximum, extrema. See #1990#1993

Merged
joa-quim merged 3 commits into
masterfrom
fix-piracies-in-extrema
Apr 29, 2026
Merged

Fix type piracies in minimum, maximum, extrema. See #1990#1993
joa-quim merged 3 commits into
masterfrom
fix-piracies-in-extrema

Conversation

@joa-quim
Copy link
Copy Markdown
Member

Also fix another type piracy with the 'names' method.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 36.84211% with 12 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@5b9e8d1). Learn more about missing BASE report.
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/gmt_types.jl 0.00% 5 Missing ⚠️
src/gmt_main.jl 0.00% 3 Missing ⚠️
src/utils.jl 70.00% 3 Missing ⚠️
src/gdal_utils.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1993   +/-   ##
=========================================
  Coverage          ?   85.09%           
=========================================
  Files             ?      191           
  Lines             ?    29048           
  Branches          ?        0           
=========================================
  Hits              ?    24718           
  Misses            ?     4330           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joa-quim joa-quim merged commit 4b2fe87 into master Apr 29, 2026
3 of 7 checks passed
@joa-quim joa-quim deleted the fix-piracies-in-extrema branch April 29, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants