Flip to WFI coords and document the flip - #1363
Merged
Merged
Conversation
Flipped the coordinate system, and added some justification/documentation
rmjarvis
added a commit
that referenced
this pull request
Aug 4, 2026
rmjarvis
added a commit
that referenced
this pull request
Aug 4, 2026
* Flip to WFI coords and document the flip Flipped the coordinate system, and added some justification/documentation * Fixed to use galsim transformation isntead --------- Co-authored-by: Nihar Dalal <140463192+nihardalal@users.noreply.github.com> Co-authored-by: nihardalal <nihardalal@rocketmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flipped the coordinate system, and added some justification/documentation
The Roman PSF had been targeting the exit pupil coordinates before applying the telescope rotation and WCS. However, that's not correct. We should be targeting WFI coordinates, which are not the same thing. There is a flip involved, which Nihar tracked down is equivalent to just flipping the y-axis of the pupil plane image.