add ensemble avg for routing and landice ( one landice member so far) - #176
Conversation
…GEOS-ESM/GEOSldas_GridComp into feature/wjiang/add_ensavg_landice_route
|
This PR is zero-diff |
|
I have checked the PR with six members of ensemble run and compared with discharge observations. The results look good. |
…GEOS_LdasGridComp.F90, GEOS_MetforceAvgGridComp.F90, GEOSldas_HIST.rc)
…ensavg_landice_route' into feature/wjiang/add_ensavg_landice_route
|
@weiyuan-jiang : Thanks again for sorting through the ensavg output across the various new GridComps, this is great! I added a couple of commits:
Please double-check these commits. The big change on develop since the present PR was started is the addition of ISSM under Landice. Since we hardwire Landice to a single ensemble member, I assume that no further action is needed to accommodate ISSM within the new Landice ensemble capability. Is that correct? Or might the addition of ISSM require changes in the revised "ensavg" GridComp? PS: I'm submitting this comment before the CI build completes. Apologies if I introduced a build error. If I did, I'll fix it tomorrow. |
…GEOS_LandiceAvgGridComp.F90)
|
@weiyuan-jiang : I don't understand why this branch built successfully yesterday. It should depend on NUM_SNOW_LAYERS and NUM_ICE_LAYERS being made public in the Landice GC, which is part of GEOS-ESM/GEOSgcm_GridComp#1421 but not on the GCM GC "develop" branch (which is presumably used by CI in the build test). In looking a bit more into this, I noticed that NUM_SNOW_LAYERS and NUM_ICE_LAYERS exist with the same names in both the Landice GC and the sea ice model (CICE). That's ok as long as the variables are not public, but now we need the variables from LANDICE to be public. To make this safer, I appended "_LANDICE" to the public name: I still don't understand why the present PR builds without seeing the branch that makes the NUM_*_LAYERS public. I did not find anything that made the sea ice variables public, maybe I missed it. Can you explain this? |
I guess it wasn't really build with develop branch but the right branch of GEOS-ESM/GEOSgcm_GridComp#1421 |
But where/how do we tell the CI build test to use the branch associated with GEOS-ESM/GEOSgcm_GridComp#1421 rather than the "develop" branch? cc: @mathomp4 |
Adds ensemble capability in GEOSldas for Route and Landice. The latter is hardwired to N_ens_landice=1 for now.
After merge, the following inputs to the GEOSldas regression test suite must be edited:
/discover/nobackup/mathomp4/LDAS_Restarts/NGHTLY_TST_TV4000/HISTORY_L4_SM.rc/discover/nobackup/mathomp4/LDAS_Restarts/NGHTLY_TST_CS/assim/ldas179b8_C180/run/HISTORY.rcThese files are used by the
GLOBAL[CS]/assimtests. Within the files, replaceENSAVGwithLANDAVG.Related PRs:
GEOS-ESM/GEOSgcm_GridComp#1421. (merged 21-July-2026)
cc: @mathomp4