Skip to content

Running ocean with different dt#135

Merged
narnold1 merged 1 commit into
feature/rc31_coupled_devfrom
feature/oceanDt.v12-rc31
Jun 29, 2026
Merged

Running ocean with different dt#135
narnold1 merged 1 commit into
feature/rc31_coupled_devfrom
feature/oceanDt.v12-rc31

Conversation

@atrayano

@atrayano atrayano commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

This PR moves the handling of the private clock to OGCM, and therefore should be merged simultaneously with PR #1461 (to GEOSgcm_GridComp repository).

@atrayano atrayano requested a review from narnold1 June 18, 2026 20:50
@atrayano atrayano self-assigned this Jun 18, 2026
@atrayano atrayano requested a review from a team as a code owner June 18, 2026 20:50
@atrayano atrayano added 0 diff dataocean Zero-diff for the dataocean model 0 diff coupled Zero-diff for the coupled model labels Jun 18, 2026
@github-actions

Copy link
Copy Markdown

This PR is being prevented from merging because you have not added one of our required labels to say if they are 0-diff or non-0-diff for dataatm runs: 0 diff dataatm, non 0-diff dataatm. Please add so that the PR can be merged.

1 similar comment
@github-actions

Copy link
Copy Markdown

This PR is being prevented from merging because you have not added one of our required labels to say if they are 0-diff or non-0-diff for dataatm runs: 0 diff dataatm, non 0-diff dataatm. Please add so that the PR can be merged.

@mathomp4

Copy link
Copy Markdown
Member

@atrayano The gfortran build error is because gfortran doesn't allow splitting macros over multiple lines:

[100%] Building Fortran object src/Components/@GEOSgcm_GridComp/CMakeFiles/GEOSgcm_GridComp.dir/gc2gc.F90.o
/root/project/GEOSgcm/src/Components/@GEOSgcm_GridComp/gc2gc.F90:85:45:

   85 |        _ASSERT(tk==ESMF_TYPEKIND_R4, &
      |                                             1
Error: Syntax error in argument list at (1)

The ifort run error is:

forrtl: severe (408): fort: (7): Attempt to use pointer VARS when it is not associated with a target

Image              PC                Routine            Line        Source             
GEOSgcm.x          00000000004EC98F  gc2gc_mp_mapl_con         259  gc2gc.F90
GEOSgcm.x          0000000000491375  geos_gcmgridcompm         706  GEOS_GcmGridComp.F90

@narnold1 narnold1 merged commit 938e347 into feature/rc31_coupled_dev Jun 29, 2026
14 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff coupled Zero-diff for the coupled model 0 diff dataocean Zero-diff for the dataocean model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants