feat(browser): preserve page appearance while native views are occluded - #2977
Merged
Conversation
- Centralize visibility and focus decisions across navigation, resizing, tab activation, and toolbar transitions - Mark shared overlays and session overview menus as native occluders - Track overlay visibility and geometry changes, including delayed bounds - Serialize native visibility calls and recheck state after async work - Add regression tests for overlapping panels and visibility races
- Preserve page appearance beneath menus and panels with decoded previews. - Bound screenshot size and sample only while native views are visible. - Invalidate stale frames and fall back when capture is unavailable. - Keep preview capture local to the controller in Peer Device Mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type and Areas
Type: Feature / bug fix / UI/UX
Areas: Desktop/Tauri, Web UI, remote surface contracts, docs
Motivation / Impact
Opening a tooltip, context menu, or session overview over the embedded browser previously exposed a generic placeholder. Cached snapshots preserve the page appearance while allowing floating surfaces to remain visible.
Snapshots now use square corners and matching native-view geometry, avoiding visible movement at fractional display scaling.
Verification
pnpm run check:web.pnpm --dir src/web-ui exec vitest run src/app/scenes/browser/browserPreviewCache.test.ts src/app/scenes/browser/nativeWebviewVisibility.test.ts src/app/scenes/browser/useEmbeddedBrowserWebview.test.tsx— 18 tests.pnpm --dir src/web-ui exec tsc --noEmitandgit diff --check.Reviewer Notes
Checklist