Skip to content

fix(ui): suppress native button hover highlights - #2975

Merged
bobleer merged 1 commit into
GCWing:mainfrom
bobleer:bob/fix-button-native-hover
Sep 11, 2026
Merged

fix(ui): suppress native button hover highlights#2975
bobleer merged 1 commit into
GCWing:mainfrom
bobleer:bob/fix-button-native-hover

Conversation

@bobleer

@bobleer bobleer commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

Disable native button appearance in shared Button and IconButton so their CSS surfaces own hover feedback. Also disable their background transitions when reduced motion is requested.

Type and Areas

Type: Bug fix / UI/UX

Areas: Shared design system, desktop/Tauri, Web UI

Motivation / Impact

The Connect Devices button was reported to flash unwanted white lines along its upper and lower edges on hover in macOS. Button and IconButton draw their hover backgrounds through pseudo-elements but left native button appearance enabled. Explicitly disabling native appearance addresses that potential source of additional WebKit highlights across both shared controls while preserving their existing background transitions and keyboard focus rings.

Verification

  • pnpm run design-system:test — passed, including component builds and Design Lab type-check. A non-fatal warning reported an occupied HMR port (24678).
  • pnpm run motion:audit — completed; the inventory reports one existing unrelated reduced-motion item in PortForwardDialog.scss.
  • git diff --check — passed.
  • macOS WebView visual reproduction and post-change visual verification were not performed; the reported white-line symptom still needs manual confirmation.
  • Remote workspace, remote control, Peer Device Mode, and Detached Dispatch were not exercised. This change only touches shared component CSS.

Reviewer Notes

Only two component stylesheets change. No token, data, protocol, or locale changes.

Checklist

  • This PR is focused and does not include secrets, temporary prompts, generated scratch files, or unrelated artifacts.
  • Relevant verification is recorded above, or skipped checks are explained.
  • User-facing strings, docs, and locales are updated where applicable.

@bobleer
bobleer merged commit 28e313c into GCWing:main Sep 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant