fix(ui): suppress native button hover highlights - #2975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable native button appearance in shared Button and IconButton so their CSS surfaces own hover feedback. Also disable their background transitions when reduced motion is requested.
Type and Areas
Type: Bug fix / UI/UX
Areas: Shared design system, desktop/Tauri, Web UI
Motivation / Impact
The Connect Devices button was reported to flash unwanted white lines along its upper and lower edges on hover in macOS. Button and IconButton draw their hover backgrounds through pseudo-elements but left native button appearance enabled. Explicitly disabling native appearance addresses that potential source of additional WebKit highlights across both shared controls while preserving their existing background transitions and keyboard focus rings.
Verification
pnpm run design-system:test— passed, including component builds and Design Lab type-check. A non-fatal warning reported an occupied HMR port (24678).pnpm run motion:audit— completed; the inventory reports one existing unrelated reduced-motion item in PortForwardDialog.scss.git diff --check— passed.Reviewer Notes
Only two component stylesheets change. No token, data, protocol, or locale changes.
Checklist