feat: unify agent identities and refine agent and skill management - #2932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unify the four built-in Agent Harness identities as
Minimal,Standard,Ultimate, andCreative, while keeping legacy configuration, persisted sessions, and peer/mobile/dispatch wire identities readable. Refine Agent and assistant configuration, reusable skill groups, and session panel ownership across the desktop and mobile surfaces.Type and Areas
Feature, refactor, and UI/UX. Shared Rust contracts/runtime, desktop and CLI adapters, Web UI, mobile web, design system, and localization.
Motivation / Impact
remote-ssh-concretefeature explicitly activates the existingcore-typesdependency used for identity wire translation. No dependency version or default feature changes are required.mainchanges to account-device routing, removal of cloud settings sync, and retirement of first-entry mode reminders.Verification
Passed locally:
pnpm run fmt:rscargo test --locked -p openbitfun-core-typescargo test --locked -p openbitfun-config-contracts --lib— 77 tests passed.cargo test --locked -p openbitfun-core --no-default-features --lib service::config::— 63 tests passed.cargo test --locked -p openbitfun-core --no-default-features --features agent-runtime,git,external-sources --lib agentic::coordination::— 173 tests passed, including legacy Swarm database and external Agent ownership regressions.cargo test --locked -p openbitfun-services-integrations --no-default-features --features remote-ssh-concrete --lib remote_ssh::manager::tests::workspace_— 24 tests passed; 2 existing opt-in diagnostics skipped.pnpm run check:web— type-check, Appearance, typography, theme color, and visual-contract gates passed.pnpm run design-system:testpnpm --dir src/mobile-web run test:ui-components— 10 tests passed.pnpm --dir src/mobile-web run type-checkpnpm run i18n:generate,pnpm run i18n:contract:test(37 passed), andpnpm run i18n:audit(zero warnings).pnpm run check:core-boundaries:test— 142 tests passed.pnpm run check:core-boundariespnpm run check:repo-hygienepnpm run motion:audit— intent inventory reviewed; not visual acceptance.node scripts/check-git-object-sizes.mjs --base origin/main --head HEADgit diff origin/main...HEAD --checkThe focused frontend command below passed all 92 tests across 8 files:
The CI regression command below also passed all 62 tests across 5 files. The text-clipping test additionally checks the compact line-height scale against the bundled font metrics.
Full automated validation is provided by the PR CI; this PR will be merged only after all applicable checks succeed on its final commit.
Reviewer Notes
AI-assisted. Testing level: focused automated tests; full CI pending. No browser automation, mock visual validation, or manual visual acceptance was performed. Compatibility fixtures cover legacy identity round trips; live SSH workspaces, remote control, Peer Device Mode, and detached dispatch were not exercised manually.
Checklist