feat(harmonyos): switch the phone UI between Chinese and English - #2369
Merged
Conversation
The in-app language never changed because RemoteI18n only had a hardcoded zh-CN map and no locale state. Keep catalogs, persistence, and Settings selection on the phone so the current surface rebuilds immediately after a switch. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The phone could show Chinese copy and nothing else.
RemoteI18nwas astatic zh-CN map, so Settings had no language control and a switch could
not rebuild the current surface.
This keeps locale ids, catalogs, and fallback on the phone itself — the
same
zh-CN/en-UScontract as the rest of the product, withoutimporting Web UI or mobile-web catalogs. First launch uses a stored
preference, then the system language, then
zh-CN. Changing language inSettings writes that preference and refreshes the open UI immediately,
including status, time, speech recognition, and permission strings.
Shared short labels such as 设置 / 未连接 are not remapped by value
alone; only unique catalog strings, or fields that name their keys, move
with the language.
The HarmonyOS architecture check no longer fails a file for crossing a
line count. Ownership still has to stay focused; do not flatten a file
just to stay under a number.
Verification:
harmony:architecture,assembleHap, and LocalTest pass.The signed HAP was installed on the connected phone and launched.
Design notes:
src/apps/mobile/harmonyos/docs/harmonyos-i18n-design.md