Skip to content

Remove ACL permissions for deleted resource #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kstribrnAmzn wants to merge 3 commits into from
+64 −0
Closed

Remove ACL permissions for deleted resource #1420

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f297bc1
Remove ACL permissions for deleted resource
kstribrnAmzn May 28, 2026
7a84a83
Skip ACL cleanup for a task deleting itself
kstribrnAmzn Jun 4, 2026
ab01b5c
Remove formatting, correct access revocation order
kstribrnAmzn Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions portable/Common/mpu_wrappers_v2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,38 @@
}
/*-----------------------------------------------------------*/

#if ( configENABLE_ACCESS_CONTROL_LIST == 1 )

static void vRevokeAccessofDeletedObjectFromAllTasks( int32_t lExternalIndexOfKernelObject ) /* PRIVILEGED_FUNCTION */
{
int32_t i;
int32_t lInternalIndexOfKernelObject;
TaskHandle_t xInternalTaskHandle;

if( IS_EXTERNAL_INDEX_VALID( lExternalIndexOfKernelObject ) != pdFALSE )
{
lInternalIndexOfKernelObject = ( int32_t ) CONVERT_TO_INTERNAL_INDEX( lExternalIndexOfKernelObject );

for( i = 0; i < configPROTECTED_KERNEL_OBJECT_POOL_SIZE; i++ )
{
if( xKernelObjectPool[ i ].ulKernelObjectType == KERNEL_OBJECT_TYPE_TASK )
{
xInternalTaskHandle = ( TaskHandle_t ) xKernelObjectPool[ i ].xInternalObjectHandle;

if( ( xInternalTaskHandle != NULL ) &&
( i != lInternalIndexOfKernelObject ) )
{
vPortRevokeAccessToKernelObject( xInternalTaskHandle,
lInternalIndexOfKernelObject );
}
}
}
}
}

#endif /* #if ( configENABLE_ACCESS_CONTROL_LIST == 1 ) */
/*-----------------------------------------------------------*/

#if ( configENABLE_ACCESS_CONTROL_LIST == 1 )

void vGrantAccessToKernelObject( TaskHandle_t xExternalTaskHandle,
Expand Down Expand Up @@ -1648,6 +1680,12 @@

if( lIndex != -1 )
{
#if ( configENABLE_ACCESS_CONTROL_LIST == 1 )
{
vRevokeAccessofDeletedObjectFromAllTasks( CONVERT_TO_EXTERNAL_INDEX( lIndex ) );
}
#endif

MPU_SetIndexFreeInKernelObjectPool( lIndex );
}

Expand All @@ -1663,6 +1701,12 @@

if( xInternalTaskHandle != NULL )
{
#if ( configENABLE_ACCESS_CONTROL_LIST == 1 )
{
vRevokeAccessofDeletedObjectFromAllTasks( lIndex );
}
#endif

MPU_SetIndexFreeInKernelObjectPool( CONVERT_TO_INTERNAL_INDEX( lIndex ) );
vTaskDelete( xInternalTaskHandle );
}
Expand Down Expand Up @@ -2759,7 +2803,14 @@

if( xInternalQueueHandle != NULL )
{
#if ( configENABLE_ACCESS_CONTROL_LIST == 1 )
{
vRevokeAccessofDeletedObjectFromAllTasks( lIndex );
}
#endif

vQueueDelete( xInternalQueueHandle );

MPU_SetIndexFreeInKernelObjectPool( CONVERT_TO_INTERNAL_INDEX( lIndex ) );
}
}
Expand Down Expand Up @@ -4246,7 +4297,14 @@

if( xInternalEventGroupHandle != NULL )
{
#if ( configENABLE_ACCESS_CONTROL_LIST == 1 )
{
vRevokeAccessofDeletedObjectFromAllTasks( lIndex );
}
#endif

vEventGroupDelete( xInternalEventGroupHandle );

MPU_SetIndexFreeInKernelObjectPool( CONVERT_TO_INTERNAL_INDEX( lIndex ) );
}
}
Expand Down Expand Up @@ -4809,6 +4867,12 @@

if( xInternalStreamBufferHandle != NULL )
{
#if ( configENABLE_ACCESS_CONTROL_LIST == 1 )
{
vRevokeAccessofDeletedObjectFromAllTasks( lIndex );
}
#endif

vStreamBufferDelete( xInternalStreamBufferHandle );
}

Expand Down
Loading