Repository navigation
If "reboot into BIOS Setup", skip UI - #5
Open
JohnAZoidberg wants to merge 1 commit into
Open
JohnAZoidberg wants to merge 1 commit into
JohnAZoidberg wants to merge 1 commit into
Conversation
This can happen in two cases: - From the OS, the user requests booting into the setup menu - On linux via `systemctl reboot --firmware` - On Windows via `shutdown /r /fw /t 0` - From the app by pressing F12 The latter case currently does not work on our hardware because the "app" is actually loaded as a driver with a depex before the setup menu. So pressing F12 will just land you back into the app. I never noticed this in my testing because I usually run it as an app from the UEFI shell. Signed-off-by: Daniel Schaefer <dhs@frame.work>
📦 Binary Size Comparison (Nix Build)
Full hashes
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Forced UI mode currently overrides the firmware-UI request and contradicts the intended skip behavior.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Skips the input-module UI when firmware setup boot is requested.
Changes:
- Detects
OsIndicationsfirmware-UI requests. - Bypasses normal UI startup when requested.
| File | Description |
|---|---|
src/state_machine.rs |
Adds firmware-UI request detection. |
src/main.rs |
Uses the request to skip UI startup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| info!("Boot to firmware UI requested, skipping UI"); | ||
| } | ||
|
|
||
| let reset = if force_ui || (show_ui && !setup_requested) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can happen in two cases:
systemctl reboot --firmwareshutdown /r /fw /t 0The latter case currently does not work on our hardware because the "app" is actually loaded as a driver with a depex before the setup menu. So pressing F12 will just land you back into the app. I never noticed this in my testing because I usually run it as an app from the UEFI shell.