Add haptic settings for Laptop 13 Pro touchpad#332
Merged
JohnAZoidberg merged 1 commit intomainfrom May 3, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds CLI support for configuring the Framework Laptop 13 Pro haptic touchpad via HID feature reports, and updates user-facing documentation and shell completions accordingly.
Changes:
- Introduces
--haptic-intensity(0/25/50/75/100) and--click-force(low/medium/high) CLI flags and wiring in the command dispatcher. - Implements HID feature-report writes in
framework_lib::touchpadfor intensity and click-force configuration. - Updates bash/zsh/fish completions and adds usage examples to
EXAMPLES.md.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| framework_tool/completions/zsh/_framework_tool | Adds zsh completion entries for the new flags and their allowed values. |
| framework_tool/completions/fish/framework_tool.fish | Adds fish completions for haptic intensity and click force. |
| framework_tool/completions/bash/framework_tool | Adds bash completions for the new flags (options list + per-flag value completion). |
| framework_lib/src/touchpad.rs | Adds HID device discovery + feature report writes for haptic intensity and click force. |
| framework_lib/src/commandline/uefi.rs | Initializes new CLI fields for UEFI builds (defaults to None). |
| framework_lib/src/commandline/mod.rs | Adds new CLI args (haptic_intensity, click_force) and hooks them into run_with_args. |
| framework_lib/src/commandline/clap_std.rs | Adds clap parsing for the new flags (including allowed-value validation). |
| EXAMPLES.md | Documents how to use the new touchpad haptics flags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JohnAZoidberg
force-pushed
the
haptic-settings
branch
from
aee7110 to
bf3a62c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
See examples for details: > framework_tool --haptic-intensity 75 > framework_tool --click-force high Signed-off-by: Daniel Schaefer <dhs@frame.work>
JohnAZoidberg
force-pushed
the
haptic-settings
branch
from
bf3a62c to
44311b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See examples for details: