BUG: Doesn't swipe left when new photos are available #652

Activity

1. soshial

   added

   bugSomething is not workingSomething is not working

   needs triageIssue is not yet ready for PR authors to take upIssue is not yet ready for PR authors to take up

   on Sep 13, 2025
2. naveensingh commented on Sep 13, 2025

   

   naveensingh

   on Sep 13, 2025

   Member

   More actions

   It'll be handled in #284
3. naveensingh

   closed this as a duplicateof Reload upon activity resume #284 on Sep 13, 2025
4. naveensingh

   added

   duplicateThis issue or pull request already existsThis issue or pull request already exists

   and removed

   bugSomething is not workingSomething is not working

   needs triageIssue is not yet ready for PR authors to take upIssue is not yet ready for PR authors to take up

   on Sep 13, 2025
5. soshial commented on Sep 13, 2025

   

   soshial

   on Sep 13, 2025

   Author

   More actions

   Thanks you, @naveensingh! Will this also work in PhotoVideoActivity? I don't see any ContentObserver there.
6. naveensingh commented on Sep 13, 2025

   

   naveensingh

   on Sep 13, 2025

   Last edited by naveensingh

   Member

   More actions

   Will this also work in PhotoVideoActivity? I don't see any ContentObserver there.

   Both PhotoVideoActivity and ViewPagerActivity inherit the SimpleActivity (which contains the observer). Just need to register the observer at the right time and reload the media when changes occur.

   👍React with 👍1Reacted by soshial
7. soshial commented on Sep 14, 2025

   

   soshial

   on Sep 14, 2025

   Last edited by soshial

   Author

   More actions

   Thanks, but I couldn't find registerFileUpdateListener() being called in PhotoVideoActivity or SimpleActivity.

   Also, I think this a badly engineered approach having it in SimpleActivity, because the same code will be executed multiple times:

       private val observer = object : ContentObserver(null) {
           override fun onChange(selfChange: Boolean, uri: Uri?) {
               super.onChange(selfChange, uri)
               if (uri != null) {
                   val path = getRealPathFromURI(uri)
                   if (path != null) {
                       updateDirectoryPath(path.getParentPath())
                       addPathToDB(path)
                   }
               }
           }
       }

   It should be launched/subscribed only once in a single place, and other activities should simply subscribe to changes.
8. naveensingh commented on Sep 14, 2025

   

   naveensingh

   on Sep 14, 2025

   Member

   More actions

   I couldn't find registerFileUpdateListener() being called in PhotoVideoActivity or SimpleActivity.

   Currently, only MainActivity and MediaActivity register the observer (by calling registerFileUpdateListener()).

   Also, note that when you are able to swipe, you are in the ViewPagerActivity, not PhotoVideoActivity.

   badly engineered approach

   Agreed. All Fossify apps don't follow the recommended architecture. There are many ancient God activities.