Repository navigation
Conversation
std::auto_ptr was deprecated in C++11 and removed in C++17. Modern MSVC defaults to C++17 or later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use std::unique_ptr for cloop's local Generator owner. The pointer is only default-constructed, reset and dereferenced, so it does not require auto_ptr's transfer-on-copy behavior. unique_ptr also removes reliance on a facility removed from the C++ standard in C++17.
Master already uses unique_ptr after the cloop update in 30d835a; this small compatibility change targets v5.0-release and retains C++11 support.
Validation on Linux x86-64 with GCC 16.2:
Windows validation and a complete Firebird 5 server build have not been run locally.