Repository navigation
Conversation
C++23 is stricter about implicit conversions that C++17 allowed: - isc_sync.cpp: return NULL in bool function -> return false - install.cpp/registry.cpp: const char* "" to LPSTR -> NULL (valid per Win32 API) - AuthSspi.cpp: const char* to SEC_CHAR* -> const_cast
dand-oss
marked this pull request as ready for review
October 7, 2026 04:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the narrow Windows type-conversion corrections to the Firebird 5 branch: return false from the bool-returning shared-memory remap error paths, explicitly adapt the SSPI package-name argument, and pass a null optional class name to RegCreateKeyEx.
Equivalent corrections are already on master in 9266b5e (the C++20 migration, #8657). This proposal keeps the surrounding Firebird 5 conventions and does not change its required language standard.
These fixes originated in Windows/MSVC work on strict C++23 builds. For this upstream submission, the patch was additionally applied cleanly to current v5.0-release, the changed calls/returns were compared with the accepted master implementation, and git diff --check passed. Windows validation was not independently rerun during submission preparation.