Repository navigation
Conversation
Skip zero-length memcpy/memmove calls in AbstractString construction and Array copy, insert, and capacity growth operations. Assert that nonempty Array storage is valid before copying during capacity growth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip memcpy/memmove when the relevant element count is zero in Array copy/insert/growth operations and when AbstractString is constructed from an empty buffer. Empty dynamically allocated arrays can have null storage, which UBSan diagnoses even when the memory-operation length is zero. Preserve count updates and nonempty operations.
This is a fresh proposal related to the closed #8848. It also covers empty-capacity growth and the length/data AbstractString constructor. The adaptation to current master retains the newer static_cast<void*> destinations and allocator signatures.
Validation on Linux x86-64 with Clang 21 / C++20 /
-fsanitize=undefined -fno-sanitize-recover=all:The isolated harness does not cover Firebird's memory-pool lifecycle. The AbstractString runtime case and a complete patched server build have not yet been completed locally.