Repository navigation
Fix crash after ping of an attachment deleted via mon$attachments - #9196
Merged
dyemanov merged 1 commit intoOct 7, 2026
Merged
Conversation
Remove the extra manual release in YAttachment::ping.
Member
|
The original code used |
dyemanov
approved these changes
Oct 6, 2026
dyemanov
pushed a commit
that referenced
this pull request
Oct 7, 2026
Remove the extra manual release in YAttachment::ping. Co-authored-by: aleksey.mochalov <aleksey.mochalov@red-soft.ru>
dyemanov
pushed a commit
that referenced
this pull request
Oct 7, 2026
Remove the extra manual release in YAttachment::ping. Co-authored-by: aleksey.mochalov <aleksey.mochalov@red-soft.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash that a customer encountered after deleting an attachment from
mon$attachments.A later
pingcorrectly reports that the connection has been shut down. The crash happens during cleanup, whenYEntrytries to release an interface that has already been destroyed.The
nextfield inYAttachmentand thenextReffield inYEntryhold references to the same interface. The manualreleasecall drops one reference, and settingnexttonullptrdrops another, destroying the object.YEntrystill holds the old pointer and tries toreleaseit when its destructor runs.The fix removes the extra manual
releaseso that eachRefPtrreleases its own reference once.