Add auth credential domain, infra & use-cases - #119
Draft
mzpx wants to merge 6 commits into
Draft
Conversation
Introduce Credential functionality across the auth module: adds Credential domain model with validation and update/create patterns; CredentialRepository and CredentialQueries protocols; database access layer (CredentialTable), repository (DatabaseCredentialRepository) and queries (DatabaseCredentialQueries); application DTOs/adapters, scopes, and use-cases (Add/Edit/Get/Remove) with authorization and password hashing; permission keys for credentials; DB migration to create auth_credentials table; and unit tests for Credential domain behavior. Also wires credential permissions into AuthPermissions and updates tests.
Updated VSCode tasks to automatically manage Docker containers: 'Ensure Local Dependencies' now runs `make docker-up` after dependencies, and 'Stop running app' now runs `make docker-down` to clean up containers.
Add complete CRUD and search API for managing user credentials in the admin panel. Includes credential creation, listing, searching, updating (PUT/PATCH), bulk deletion, and filtering. Implements both application-layer use cases and HTTP handlers following FATHOMS pattern. Adds new CredentialList DTO and extends auth permissions with list action.
Add a dedicated UserCredentialSearchFilterSchema to the OpenAPI spec (admin.yaml and versioned files) and regenerate client types. Update server to return the new filter shape (default search="", accountID=nil) and normalize empty accountID to nil when searching. Update generated response mapping and tests to expect the new schema. This makes credential list filtering explicit and avoids treating empty account IDs as real values.
Register DatabaseCredentialRepository in AuthModule builders and add CredentialRepository to the WriteAuth scope. Update SignInWithCredentials to fetch the credential first, verify the password against credential.passwordHash, and then load the account by credential.accountID. Add credential seeding to TableSeedMigration: import BCrypt and NIOPosix, hash initial passwords on the NIOThreadPool, and insert auth_credentials rows (root/manager/user). This centralizes credential access and seeds initial credentials securely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce Credential functionality across the auth module: adds Credential domain model with validation and update/create patterns; CredentialRepository and CredentialQueries protocols; database access layer (CredentialTable), repository (DatabaseCredentialRepository) and queries (DatabaseCredentialQueries); application DTOs/adapters, scopes, and use-cases (Add/Edit/Get/Remove) with authorization and password hashing; permission keys for credentials; DB migration to create auth_credentials table; and unit tests for Credential domain behavior. Also wires credential permissions into AuthPermissions and updates tests.