Fix: return to Agents list when tapping back on a newly created agent DM - #97868
Draft
MelvinBot wants to merge 1 commit into
Draft
Fix: return to Agents list when tapping back on a newly created agent DM#97868MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
… DM (narrow) Co-authored-by: Michał Jasikowski <mjasikowski@users.noreply.github.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
On narrow (native) layouts, creating an agent revealed the new DM as a fullscreen report and then dismissed the entire Settings → Agents → New agent modal stack (
revealRouteBeforeDismissingModal). That left the Agents list off the back stack, so tapping back on the agent chat fell through to the LHN instead of returning to Agents.This passes a
backToparam pointing at the Agents list (ROUTES.SETTINGS_AGENTS) when revealing the DM, so the report header's back button (ReportHeader.onBackButtonPress→Navigation.goBack(backTo)) returns to the Agents list as expected.Wide layouts are unchanged: they already open the DM inside the RHP (
AGENT_REPORTwithforceReplace) and correctly return to Agents. Only the narrow-layout branch is affected. Follow-up to #95631.Fixed Issues
$ #97832
PROPOSAL:
Tests
// TODO: The human co-author must confirm the tests below before marking this PR as "ready for review".
Suggested steps (on a narrow layout — native app or a narrow browser window):
Offline tests
Same as tests — the agent create + navigation flow is fully optimistic and works online or offline.
QA Steps
// TODO: The human co-author must confirm the QA steps before marking this PR as "ready for review". Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari