Show a page count badge on multi-page PDF receipts

[ishpaul777]

Explanation of Change

A PDF receipt's thumbnail is a server-generated JPG of page 1. When a multi-page receipt's total sits on page 2 or later, the expense looks like it disagrees with its own receipt, and nothing on screen signals that more pages exist. Hover-zoom does not help — it magnifies the same first page.

This adds a Page 1 of N badge over the receipt in the expense detail view, gated on pageCount > 1.

Two design decisions, since design has not weighed in yet (the issue is still waiting on @Expensify/design):

• Bottom-left. The receipt action buttons already own the top-right corner on hover.
• Translucent dark pill with a page-stack icon. It sits over arbitrary receipt content, so it cannot rely on theme background colors for contrast. It reuses theme.videoPlayerBG — the same translucent dark already used for controls over video — paired with theme.white, which reads correctly in both themes. The page-stack icon is included because the original complaint was that users do not notice multi-page receipts at all, so an icon gives it a shape to catch the eye before the text is read.

Happy to change the copy, position, or drop the icon once design responds.

This depends on three backend PRs and shows nothing until they ship, since pageCount does not exist on any receipt today:

• Web-PDFs: https://github.com/Expensify/Web-PDFs/pull/676
• Web-Expensify: https://github.com/Expensify/Web-Expensify/pull/55107
• Auth: https://github.com/Expensify/Auth/pull/23463

There is no backfill, so the badge only ever appears on receipts uploaded after the backend ships. The pageCount > 1 gate handles that with no extra code.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/667914
PROPOSAL:

Tests

Requires the three backend PRs running locally.

1. Submit an expense and attach a PDF receipt with 3 pages where the total appears only on the last page.
2. Open the expense detail view.
3. Verify a Page 1 of 3 badge appears at the bottom-left of the receipt.
4. Verify the badge does not overlap the receipt action buttons when hovering the receipt.
5. Submit an expense with a single-page PDF receipt and verify no badge appears.
6. Submit an expense with an image receipt and verify no badge appears.
7. Open an expense created before the backend change and verify no badge appears and no errors occur.
8. Switch between light and dark theme and verify the badge stays legible in both.
9. Verify the badge does not appear anywhere outside the expense detail view.

• Verify that no errors appear in the JS console

Offline tests

The page count arrives with the transaction from Onyx and is not fetched separately, so a cached expense keeps its badge offline.

1. Open an expense with a multi-page PDF receipt while online and confirm the badge shows.
2. Disconnect the network.
3. Reopen the expense and verify the badge still shows.

QA Steps

Same as tests. Requires the three backend PRs deployed — the badge cannot appear before then, and only on receipts uploaded after they ship.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Pending — the three backend PRs are still in draft, so screenshots need a local build with all of them running. Will attach before taking this out of draft.

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main