[Part 27] Remove Onyx.connect from LocalePhoneNumber - #97800
Open
marufsharifi wants to merge 6 commits into
Open
[Part 27] Remove Onyx.connect from LocalePhoneNumber#97800marufsharifi wants to merge 6 commits into
marufsharifi wants to merge 6 commits into
Conversation
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
@shubham1206agra, could you please take a look at this pr when you get a chance? thanks. the failure actions are not related to our changes. BTW |
Contributor
|
PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself. |
trjExpensify
removed their request for review
August 5, 2026 21:49
…part-26' into fix/66327-sidebar-utils-part-27
Contributor
Author
|
@shubham1206agra, Gentle bump. thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Refactor
formatPhoneNumberinSidebarsUtils.tsThis PR also updates the Enable Travel legal-name step to use
formatPhoneNumberfromuseLocalize()instead of importing it directly fromLocalePhoneNumber.A focused test was added to verify the legal-name step submits trimmed names with the localized formatter and advances to the next step.
Fixed Issues
$ #66327
PROPOSAL:
Tests
Offline tests
QA Steps
Case 1: Verify a country phone number in a direct chat
Precondition: Have a chat participant whose login is a phone number.
Start or open a direct chat with the phone-number user.
Verify the phone number is displayed in the expected national format in the:
Send a message and navigate away from the chat.
Verify the phone number and message preview are displayed correctly in the LHN.
Reopen the chat.
Verify the phone number remains correctly formatted.
Case 2: Verify phone numbers in a group chat
Case 3: Verify an individual invoice-room welcome message
Precondition: The individual invoice recipient must use a phone number as their login and must not have a display name.
Case 4: Travel Legal Name Step.
More features.Travel.Travelpage in workspace settings.Let’s go.Book travelpanel opens withWhat’s your legal name?.Legal first name.Legal last name.Next.// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Case 1: Verify a country phone number in a direct chat
Screencast.From.2026-08-04.22-36-01.webm
Case 2: Verify phone numbers in a group chat
Screencast.From.2026-08-04.22-37-24.webm
Case 3: Verify an individual invoice-room welcome message
Screencast.From.2026-08-04.22-39-37.webm
Case 4: Travel Legal Name Step.
Screencast.From.2026-07-30.23-42-14.webm