Skip to content

[Part 27] Remove Onyx.connect from LocalePhoneNumber - #97800

Open
marufsharifi wants to merge 6 commits into
Expensify:mainfrom
marufsharifi:fix/66327-sidebar-utils-part-27
Open

[Part 27] Remove Onyx.connect from LocalePhoneNumber#97800
marufsharifi wants to merge 6 commits into
Expensify:mainfrom
marufsharifi:fix/66327-sidebar-utils-part-27

Conversation

@marufsharifi

@marufsharifi marufsharifi commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Refactor formatPhoneNumber in SidebarsUtils.ts

This PR also updates the Enable Travel legal-name step to use formatPhoneNumber from useLocalize() instead of importing it directly from LocalePhoneNumber.

A focused test was added to verify the legal-name step submits trimmed names with the localized formatter and advances to the next step.

Fixed Issues

$ #66327
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Case 1: Verify a country phone number in a direct chat

Precondition: Have a chat participant whose login is a phone number.

  1. Start or open a direct chat with the phone-number user.

  2. Verify the phone number is displayed in the expected national format in the:

    • LHN chat title
    • Chat header
    • “This chat is with…” welcome message
  3. Send a message and navigate away from the chat.

  4. Verify the phone number and message preview are displayed correctly in the LHN.

  5. Reopen the chat.

  6. Verify the phone number remains correctly formatted.

Case 2: Verify phone numbers in a group chat

  1. Create a group chat containing the same-country and different-country phone-number users.
  2. Open the group chat.
  3. Verify the beginning-of-chat welcome message displays both participants’ phone numbers correctly.
  4. Navigate away from the group chat.
  5. Verify the group chat appears correctly in the LHN.
  6. Reopen the group chat and verify the welcome message remains correct.

Case 3: Verify an individual invoice-room welcome message

Precondition: The individual invoice recipient must use a phone number as their login and must not have a display name.

  1. Send an invoice to the individual phone-number user.
  2. Open the generated invoice room.
  3. Verify the beginning-of-chat invoice message displays the individual’s correctly formatted phone number.
  4. Navigate away from the invoice room and reopen it.
  5. Verify the phone number remains correctly formatted.

Case 4: Travel Legal Name Step.

  1. Sign in with a new Expensify account.
  2. Create a new workspace.
  3. Go to the workspace settings.
  4. Go to More features.
  5. Enable Travel.
  6. Open the Travel page in workspace settings.
  7. Click Let’s go.
  8. Verify the Book travel panel opens with What’s your legal name?.
  9. Enter a value in Legal first name.
  10. Enter a value in Legal last name.
  11. Click Next.
  12. Verify the flow advances successfully and shows the travel request confirmation/request sent state.

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Case 1: Verify a country phone number in a direct chat

Screencast.From.2026-08-04.22-36-01.webm

Case 2: Verify phone numbers in a group chat

Screencast.From.2026-08-04.22-37-24.webm

Case 3: Verify an individual invoice-room welcome message

Screencast.From.2026-08-04.22-39-37.webm

Case 4: Travel Legal Name Step.

Screencast.From.2026-07-30.23-42-14.webm

@marufsharifi
marufsharifi marked this pull request as ready for review August 5, 2026 11:59
@marufsharifi
marufsharifi requested review from a team as code owners August 5, 2026 11:59
@melvin-bot

melvin-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed request for a team August 5, 2026 11:59
@marufsharifi

Copy link
Copy Markdown
Contributor Author

@shubham1206agra, could you please take a look at this pr when you get a chance? thanks.

the failure actions are not related to our changes. BTW

@trjExpensify

Copy link
Copy Markdown
Contributor

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

@trjExpensify
trjExpensify removed their request for review August 5, 2026 21:49
…part-26' into fix/66327-sidebar-utils-part-27
@marufsharifi

Copy link
Copy Markdown
Contributor Author

@shubham1206agra, Gentle bump. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants