Stop a client-side session age check from signing users out and dropping GPS trips - #97787
Draft
allgandalf wants to merge 9 commits into
Draft
Stop a client-side session age check from signing users out and dropping GPS trips#97787allgandalf wants to merge 9 commits into
allgandalf wants to merge 9 commits into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
isExpiredSessionis a 2 hour client-side check onsession.creationDatethat never looks at whether the token is actually valid. On a SAML account it sendsreauthenticate()straight toredirectToSignIn, and theOnyx.clearthere wipes the in-progress GPS trip. Attachment images now keep serving the token we already have when a background refresh is not possible, and a live trip survives the forced re-auth, owner-checked so another user can never resume it.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/665676
$ #92435
PROPOSAL: n/a
Tests
session.creationDatemore than 2 hours into the past.Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari