Remove Onyx.connect() for the key: ONYXKEYS.PERSONAL_DETAILS_LIST in src/libs/ReportNameUtils.ts by hoangzinh · Pull Request #97785 · Expensify/App

hoangzinh · 2026-08-04T11:41:38Z

Explanation of Change

Removes Onyx.connect() on ONYXKEYS.PERSONAL_DETAILS_LIST in src/libs/ReportNameUtils.ts as part of the Onyx.connect deprecation migration (parent: Expensify/Expensify#522215).

Instead of reading personal details from a JS in mem, they are now threaded explicitly through the report-name computation. This makes report-name computation a pure function of its inputs.

Fixed Issues

$ #76425
PROPOSAL:

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

Same as QA

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Open an invoice report where the invoice receiver is an individual (another user). Verify the report name in the report header shows that user's display name (unchanged).
Open an invoice room where you are the receiver. Verify the name shows the sender workspace name (unchanged).
Open a thread whose parent is an invoice report and verify the parent-navigation subtitle (breadcrumb) shows the correct invoice payer name x invoice receiver name (unchanged).
In a Money Request Report Preview inside an invoice room, verify the preview message shows the correct payer name ("X owes/paid$Y") (unchanged).

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Screen.Recording.2026-08-04.at.21.59.50.mov

Drop the module-level `Onyx.connect()` on `ONYXKEYS.PERSONAL_DETAILS_LIST` in `ReportNameUtils.ts` as part of the Onyx.connect deprecation migration (Expensify#76425). Personal details are now threaded explicitly: - `getMoneyRequestReportName` takes a required `personalDetailsList` param and resolves the invoice receiver's detail internally. - `getInvoiceReportName` / `getInvoicePayerName` accept the resolved detail/list as params (required args reordered ahead of optional ones). - `getChatListItemReportName` in ReportUtils receives `personalDetailsList` from its only caller, `SearchActionHeader`, via `useOnyx`. This removes a hidden global dependency so report-name computation is a pure function of its inputs. `getParentNavigationSubtitle` keeps using ReportUtils' own `allPersonalDetails` global (tracked separately, out of scope here). Tests updated to pass personal details explicitly, including a regression test covering the invoice payer-name resolution chain.

…Name Make the `personalDetails` param mandatory (key required, value may be undefined) so the compiler rejects any caller that omits it. Prevents a silent blank individual-receiver name now that the `allPersonalDetails` global fallback is gone.

The individual-invoice-receiver personal-detail resolution was duplicated in `getMoneyRequestReportName` (ReportNameUtils) and `getParentNavigationSubtitle` (ReportUtils). Extract it into a shared `getInvoiceReceiverPersonalDetail(report, personalDetailsList)` helper next to `getInvoiceReceiverPolicyID`, and reuse it in both call sites. Add unit specs covering individual, business, missing-account, and empty-input cases.

Trim the verbose test title and drop the implementation-detail comment on the threaded-chain invoice payer-name test; the assertion already documents the behavior.

codecov · 2026-08-04T11:49:10Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/ReportNameUtils.ts	`81.75% <100.00%> (-0.13%)`	⬇️
src/libs/ReportUtils.ts	`86.94% <100.00%> (-0.02%)`	⬇️
...RequestReportPreview/usePreviewMessageAnimation.ts	`80.00% <0.00%> (ø)`
src/pages/inbox/report/SearchActionHeader.tsx	`21.05% <0.00%> (-1.17%)`	⬇️
... and 4 files with indirect coverage changes

melvin-bot · 2026-08-04T15:05:42Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 741ef0a72a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

SearchActionHeaderContent renders per report-action list item, so `useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST)` opened a separate full-list subscription for every row. Switch to the shared `usePersonalDetails()` hook from OnyxListItemProvider — the optimized single-subscription access pattern for list items — avoiding the per-row memory overhead and update cascades.

trjExpensify · 2026-08-04T22:43:53Z

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

shubham1206agra · 2026-08-06T12:03:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-08-06.at.5.32.20.PM.mov

melvin-bot · 2026-08-06T12:03:30Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #76425 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

rlinoz

Thanks!

rlinoz · 2026-08-06T15:46:14Z

@hoangzinh conflicts.

hoangzinh · 2026-08-07T02:12:31Z

@hoangzinh conflicts.

I resolved conflicts @rlinoz

hoangzinh added 2 commits August 3, 2026 20:50

melvin-bot Bot assigned hoangzinh Aug 4, 2026

hoangzinh added 2 commits August 4, 2026 18:42

test(ReportNameUtils): simplify invoice payer-name test description

741ef0a

Trim the verbose test title and drop the implementation-detail comment on the threaded-chain invoice payer-name test; the assertion already documents the behavior.

hoangzinh marked this pull request as ready for review August 4, 2026 15:05

hoangzinh requested review from a team as code owners August 4, 2026 15:05

melvin-bot Bot requested review from shubham1206agra and trjExpensify and removed request for a team August 4, 2026 15:05

melvin-bot Bot removed the request for review from a team August 4, 2026 15:05

github-actions Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread src/pages/inbox/report/SearchActionHeader.tsx Outdated

chatgpt-codex-connector Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread src/pages/inbox/report/SearchActionHeader.tsx Outdated

trjExpensify removed their request for review August 4, 2026 22:44

Merge branch 'main' into refactor/reportnameutils-onyxconnect-76425

e978b48

shubham1206agra approved these changes Aug 6, 2026

View reviewed changes

melvin-bot Bot requested a review from rlinoz August 6, 2026 12:03

rlinoz previously approved these changes Aug 6, 2026

View reviewed changes

Merge branch 'main' into refactor/reportnameutils-onyxconnect-76425

a6c5b6e

hoangzinh dismissed rlinoz’s stale review via a6c5b6e August 7, 2026 00:46

Navigation Menu

Uh oh!

Remove Onyx.connect() for the key: ONYXKEYS.PERSONAL_DETAILS_LIST in src/libs/ReportNameUtils.ts - #97785

Remove Onyx.connect() for the key: ONYXKEYS.PERSONAL_DETAILS_LIST in src/libs/ReportNameUtils.ts#97785
hoangzinh wants to merge 7 commits into
Expensify:mainfrom
hoangzinh:refactor/reportnameutils-onyxconnect-76425

hoangzinh commented Aug 4, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Aug 4, 2026 •

edited by github-actions Bot

Loading

Uh oh!

melvin-bot Bot commented Aug 4, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

trjExpensify commented Aug 4, 2026

Uh oh!

shubham1206agra commented Aug 6, 2026

Uh oh!

melvin-bot Bot commented Aug 6, 2026

Uh oh!

rlinoz left a comment

Uh oh!

rlinoz commented Aug 6, 2026

Uh oh!

hoangzinh commented Aug 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

hoangzinh commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Aug 4, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Aug 4, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

trjExpensify commented Aug 4, 2026

Uh oh!

shubham1206agra commented Aug 6, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 6, 2026

Uh oh!

rlinoz left a comment

Choose a reason for hiding this comment

Uh oh!

rlinoz commented Aug 6, 2026

Uh oh!

hoangzinh commented Aug 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hoangzinh commented Aug 4, 2026 •

edited

Loading

codecov Bot commented Aug 4, 2026 •

edited by github-actions Bot

Loading