[No QA] Update Two-Factor-Authentication.md#90943
Conversation
Resource Updates for Expensify/Expensify#626857 (Classic) Just changed the following: - New file name - Noted that after May 2026, Recovery Codes are automatically downloaded
|
@stephanieelliott curious if you think we need to change the |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
HelpDot Documentation ReviewOverall AssessmentThis PR updates the Two-Factor Authentication article for Expensify Classic to reflect a product change: 2FA recovery codes are now automatically downloaded rather than manually copied/downloaded by the user. The changes are limited to two sections -- a procedural step and an FAQ answer. The update is straightforward and accurately communicates the new behavior. Scores Summary
Key Findings
Recommendations
Files Reviewed
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ade8aa7cff
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
github-actions
Bot
changed the title
|
A preview of your ExpensifyHelp changes have been deployed to https://14fa86bb.helpdot.pages.dev ⚡️ Updated articles: |
I agree with you @jliexpensify! Let's ignore that one |
|
@jliexpensify give me a bump when this one is ready for review! |
|
@stephanieelliott both the 2FA PR's are good for a review! |
|
Nice! Merging this one |
|
@stephanieelliott looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
| 4. Save a copy of your backup codes: | ||
| - Click **Download** to save them to your computer. | ||
| - Click **Copy** to store them in a secure location. | ||
| 4. Your Recovery Codes will be automatically saved onto the computer or device where two-factor authentication was set up: |
There was a problem hiding this comment.
Step formatting violation (HELP_AUTHORING_GUIDELINES.md Section 5): Numbered steps must be action-oriented — they should instruct the user to do something. This step is a passive statement ("Your Recovery Codes will be automatically saved...") rather than a user action.
Consider rewriting as an action, e.g.:
4. Save your Recovery Codes, which are automatically downloaded to the computer or device where two-factor authentication was set up.
Also: "Recovery Codes" is capitalized here and on line 81, but the rest of the article (lines 27, 40, 61) uses lowercase "recovery codes." Please ensure consistent casing that matches the UI exactly (per HELPSITE_NAMING_CONVENTIONS.md Core UI Referencing Rules).
| - Click **Download** to save them to your computer. | ||
| - Click **Copy** to store them in a secure location. | ||
| 4. Your Recovery Codes will be automatically saved onto the computer or device where two-factor authentication was set up: | ||
| - However, we also recommend copying and storing them in a secure location. |
There was a problem hiding this comment.
Readability / structure: Starting a sub-step with "However" is awkward and weakens the instruction. Since this is the only sub-bullet, the colon + single-item list structure on line 20 is unnecessary. Consider folding this into the main step as a direct recommendation, e.g.:
4. Save your Recovery Codes, which are automatically downloaded to your device. We recommend also copying and storing them in a separate secure location.
| When you enable 2FA, you are prompted to either copy or download backup codes which you can use in lieu of the 6-digit authenticator code. If you downloaded the codes they will be saved with the file name `two-factor-auth-codes`. | ||
| When you enable 2FA, Expensify will automatically download a set of Recovery Codes, which you can use in lieu of the 6-digit authenticator code to regain access to your account. | ||
|
|
||
| As long as you set up 2FA after May 2026, the codes will be automatically added to your device's Downloads folder under the file name `DO-NOT-DELETE_Expensify-2FA-RecoveryCodes`. |
There was a problem hiding this comment.
Readability: "As long as you set up 2FA after May 2026" is time-sensitive language that will become outdated and confusing for future readers. HelpDot articles should use durable, evergreen phrasing. Consider removing the date qualifier or rephrasing to something like: "Recovery Codes are automatically added to your device's Downloads folder under the file name DO-NOT-DELETE_Expensify-2FA-RecoveryCodes." If a historical note is truly needed, move it to a less prominent position.
HelpDot Documentation ReviewOverall AssessmentThis PR updates the Two-Factor Authentication article for Expensify Classic to reflect a product change: Recovery Codes are now automatically downloaded rather than requiring the user to manually click Download or Copy. The changes are small (5 additions, 4 deletions) and limited to one file. The updates are factually aligned with the new product behavior and improve accuracy. Scores Summary
Key Findings
Recommendations
Files Reviewed
Review based on docs/HELP_AUTHORING_GUIDELINES.md, docs/HELPSITE_NAMING_CONVENTIONS.md, and docs/TEMPLATE.md governance standards. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.80-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.81-2 🚀
|
3 participants
Resource Updates for Expensify/Expensify#626857 (Classic)
Just changed the following: