[No QA] Update Two-Factor-Authentication.md#90942
Conversation
Resource Updates for Expensify/Expensify#626857
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c6bf11aec5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
HelpDot Documentation ReviewOverall AssessmentThis PR updates the Two-Factor Authentication article to reflect a product change: recovery codes are now automatically downloaded rather than requiring the user to manually click Download or Copy. The changes are localized to the setup steps and one FAQ answer. The updates are generally clear but introduce a few style and accuracy concerns worth addressing. Scores Summary
Key Findings
Recommendations
Files Reviewed
Review based on governance rules defined in docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md. |
|
A preview of your ExpensifyHelp changes have been deployed to https://679c83ad.helpdot.pages.dev ⚡️ Updated articles: |
| - Click **Copy** to store them in a secure location. | ||
| 5. Click **Continue**. | ||
| 6. Open your authenticator app and either: | ||
| 5. Your Recovery Codes will be automatically saved onto the computer or device where two-factor authentication was set up: |
There was a problem hiding this comment.
Step formatting violation: Step 5 describes a system behavior ("Your Recovery Codes will be automatically saved..."), not a user action. Per HELP_AUTHORING_GUIDELINES.md Section 5, all step instructions must be "action-oriented."
Consider reframing as a user action, e.g.:
5. Save a copy of your Recovery Codes (automatically downloaded to your device).
This keeps the step action-oriented while conveying the auto-download behavior.
| 5. Click **Continue**. | ||
| 6. Open your authenticator app and either: | ||
| 5. Your Recovery Codes will be automatically saved onto the computer or device where two-factor authentication was set up: | ||
| - However, we also recommend copying and storing them in a secure location. |
There was a problem hiding this comment.
Style / tone: The sub-bullet "However, we also recommend..." uses first-person ("we") and starts with a hedging word ("However"). HelpDot articles should be concise and direct. Consider rephrasing to remove first-person and make the recommendation clearer, e.g.:
- Copy and store them in a separate secure location as a backup.
| When you enable 2FA, you are prompted to either copy or download backup codes which you can use in lieu of the 6-digit authenticator code. If you downloaded the codes they will be saved with the file name `two-factor-auth-codes`. | ||
| When you enable 2FA, Expensify will automatically download a set of Recovery Codes, which you can use in lieu of the 6-digit authenticator code to regain access to your account. | ||
|
|
||
| As long as you set up 2FA after May 2026, the codes will be automatically added to your device's Downloads folder under the file name `DO-NOT-DELETE_Expensify-2FA-RecoveryCodes`. |
There was a problem hiding this comment.
Readability / future-proofing: "As long as you set up 2FA after May 2026" introduces a temporal condition that will become confusing over time as more readers will have set up 2FA after that date. Consider removing the date condition or rephrasing to be evergreen, e.g.:
The codes are automatically added to your device's Downloads folder under the file name \DO-NOT-DELETE_Expensify-2FA-RecoveryCodes`.`
HelpDot Documentation ReviewOverall AssessmentThis PR updates the Two-Factor Authentication article to reflect a product change: recovery codes are now automatically downloaded rather than requiring manual copy/download. The changes are focused and factual, updating steps 4-7 of the enable flow and revising the FAQ answer about recovery codes. Scores Summary
Key Findings
Recommendations
Files Reviewed
|
| ## What can I do if I can't access my authenticator app? | ||
|
|
||
| When you enable 2FA, you are prompted to either copy or download backup codes which you can use in lieu of the 6-digit authenticator code. If you downloaded the codes they will be saved with the file name `two-factor-auth-codes`. | ||
| When you enable 2FA, Expensify will automatically download a set of Recovery Codes, which you can use in lieu of the 6-digit authenticator code to regain access to your account. |
There was a problem hiding this comment.
Style / tone: "Expensify will automatically download a set of Recovery Codes" uses first-person brand voice ("Expensify will"). For consistency with the deterministic, user-focused writing style required by HELPSITE_NAMING_CONVENTIONS.md, consider reframing from the user's perspective, e.g.:
When you enable 2FA, a set of Recovery Codes is automatically downloaded to your device. You can use these codes in lieu of the 6-digit authenticator code to regain access to your account.
|
@stephanieelliott looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.80-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.81-2 🚀
|
Resource Updates for https://github.com/Expensify/Expensify/issues/626857
Just changed the following: