Skip to content

Update wallet Assigned Cards copy#90936

Merged
chuckdries merged 3 commits into
mainfrom
claude-updateWalletAssignedCardsCopy
May 21, 2026
Merged

Update wallet Assigned Cards copy#90936
chuckdries merged 3 commits into
mainfrom
claude-updateWalletAssignedCardsCopy

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

@MelvinBot MelvinBot commented May 18, 2026

Explanation of Change

Update the wallet "Assigned Cards" section copy per design request:

  • Rename the section header from "Assigned cards" to "Cards"
  • Change description from "Transactions from these cards sync automatically." to "Transactions from assigned cards sync automatically."

Also updated the corresponding help doc section header to match.

Fixed Issues

$ #90935

Tests

  • Verify that no errors appear in the JS console
  • Open the app and navigate to Settings > Wallet
  • If you have assigned cards, verify the section header reads "Cards" (not "Assigned cards")
  • Verify the description reads "Transactions from assigned cards sync automatically."

Offline tests

N/A — copy-only change with no behavioral impact.

QA Steps

  • Verify that no errors appear in the JS console
  • Open the app and navigate to Settings > Wallet
  • If you have assigned cards, verify the section header reads "Cards" (not "Assigned cards")
  • Verify the description reads "Transactions from assigned cards sync automatically."
  • Switch app language (e.g. to Spanish) and verify the translated strings also reflect the updated copy

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Update the wallet section header from 'Assigned cards' to 'Cards' and change
the description from 'Transactions from these cards sync automatically.' to
'Transactions from assigned cards sync automatically.'

Co-authored-by: flaviadefaria <flaviadefaria@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

Your New Help changes have been deployed to https://f713def2.newhelp.pages.dev ⚡️

@OSBotify
Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/de.ts b/src/languages/de.ts
index d0ec1b41..e41d155f 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -2405,8 +2405,8 @@ const translations: TranslationDeepObject<typeof en> = {
         addBankAccountToSendAndReceive: 'Füge ein Bankkonto hinzu, um Zahlungen zu senden oder zu empfangen.',
         addDebitOrCreditCard: 'Debit- oder Kreditkarte hinzufügen',
         cardInactive: 'Inaktiv',
-        assignedCards: 'Zugewiesene Karten',
-        assignedCardsDescription: 'Transaktionen von diesen Karten werden automatisch synchronisiert.',
+        assignedCards: 'Karten',
+        assignedCardsDescription: 'Transaktionen von zugewiesenen Karten werden automatisch synchronisiert.',
         expensifyCard: 'Expensify Karte',
         walletActivationPending: 'Wir überprüfen gerade Ihre Angaben. Bitte schauen Sie in ein paar Minuten noch einmal vorbei!',
         walletActivationFailed: 'Leider kann Ihre Wallet derzeit nicht aktiviert werden. Bitte chatten Sie mit Concierge, um weitere Unterstützung zu erhalten.',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index b0f57518..81e90a71 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -2289,8 +2289,8 @@ const translations: TranslationDeepObject<typeof en> = {
         addBankAccountToSendAndReceive: 'Añade una cuenta bancaria para hacer o recibir pagos.',
         addDebitOrCreditCard: 'Añadir tarjeta de débito o crédito',
         cardInactive: 'Inactiva',
-        assignedCards: 'Tarjetas asignadas',
-        assignedCardsDescription: 'Las transacciones de estas tarjetas se sincronizan automáticamente.',
+        assignedCards: 'Tarjetas',
+        assignedCardsDescription: 'Las transacciones de las tarjetas asignadas se sincronizan automáticamente.',
         expensifyCard: 'Tarjeta Expensify',
         walletActivationPending: 'Estamos revisando tu información. Por favor, vuelve en unos minutos.',
         walletActivationFailed: 'Lamentablemente, no podemos activar tu billetera en este momento. Chatea con Concierge para obtener más ayuda.',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 9f9ca887..fc50240e 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -2410,8 +2410,8 @@ const translations: TranslationDeepObject<typeof en> = {
         addBankAccountToSendAndReceive: 'Ajoutez un compte bancaire pour effectuer ou recevoir des paiements.',
         addDebitOrCreditCard: 'Ajouter une carte de débit ou de crédit',
         cardInactive: 'Inactif',
-        assignedCards: 'Cartes assignées',
-        assignedCardsDescription: 'Les transactions de ces cartes se synchronisent automatiquement.',
+        assignedCards: 'Cartes',
+        assignedCardsDescription: 'Les transactions des cartes assignées se synchronisent automatiquement.',
         expensifyCard: 'Carte Expensify',
         walletActivationPending: 'Nous examinons vos informations. Veuillez revenir vérifier dans quelques minutes !',
         walletActivationFailed: 'Malheureusement, votre portefeuille ne peut pas être activé pour le moment. Veuillez discuter avec Concierge pour obtenir une assistance supplémentaire.',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index bc2372f9..8b41fbc0 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -2403,8 +2403,8 @@ const translations: TranslationDeepObject<typeof en> = {
         addBankAccountToSendAndReceive: 'Aggiungi un conto bancario per effettuare o ricevere pagamenti.',
         addDebitOrCreditCard: 'Aggiungi carta di debito o di credito',
         cardInactive: 'Inattivo',
-        assignedCards: 'Carte assegnate',
-        assignedCardsDescription: 'Le transazioni di queste carte si sincronizzano automaticamente.',
+        assignedCards: 'Carte',
+        assignedCardsDescription: 'Le transazioni delle carte assegnate si sincronizzano automaticamente.',
         expensifyCard: 'Carta Expensify',
         walletActivationPending: 'Stiamo verificando le tue informazioni. Riprova tra qualche minuto!',
         walletActivationFailed: 'Sfortunatamente, il tuo portafoglio non può essere abilitato in questo momento. Chatta con Concierge per ulteriore assistenza.',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index ce667514..dc1e77f4 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -2381,8 +2381,8 @@ const translations: TranslationDeepObject<typeof en> = {
         addBankAccountToSendAndReceive: '支払いや入金を行うには銀行口座を追加してください。',
         addDebitOrCreditCard: 'デビットカードまたはクレジットカードを追加',
         cardInactive: '非アクティブ',
-        assignedCards: '割り当て済みカード',
-        assignedCardsDescription: 'これらのカードからの取引は自動的に同期されます。',
+        assignedCards: 'カード',
+        assignedCardsDescription: '割り当てられたカードの取引は自動的に同期されます。',
         expensifyCard: 'Expensify カード',
         walletActivationPending: 'お客様の情報を確認しています。数分後にもう一度ご確認ください。',
         walletActivationFailed: '申し訳ありませんが、現在はウォレットを有効にできません。詳しいサポートについてはConciergeにチャットでお問い合わせください。',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index f49b1a73..caa8b3e6 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -2399,8 +2399,8 @@ const translations: TranslationDeepObject<typeof en> = {
         addBankAccountToSendAndReceive: 'Voeg een bankrekening toe om betalingen te doen of te ontvangen.',
         addDebitOrCreditCard: 'Debet- of creditcard toevoegen',
         cardInactive: 'Inactief',
-        assignedCards: 'Toegewezen kaarten',
-        assignedCardsDescription: 'Transacties van deze kaarten worden automatisch gesynchroniseerd.',
+        assignedCards: 'Kaarten',
+        assignedCardsDescription: 'Transacties van toegewezen kaarten worden automatisch gesynchroniseerd.',
         expensifyCard: 'Expensify Kaart',
         walletActivationPending: 'We controleren je gegevens. Kom over een paar minuten terug!',
         walletActivationFailed: 'Helaas kan je wallet op dit moment niet worden ingeschakeld. Chat met Concierge voor verdere hulp.',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 7494a45a..bbd018cb 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -2399,8 +2399,8 @@ const translations: TranslationDeepObject<typeof en> = {
         addBankAccountToSendAndReceive: 'Dodaj konto bankowe, aby wysyłać lub odbierać płatności.',
         addDebitOrCreditCard: 'Dodaj kartę debetową lub kredytową',
         cardInactive: 'Nieaktywne',
-        assignedCards: 'Przypisane karty',
-        assignedCardsDescription: 'Transakcje z tych kart synchronizują się automatycznie.',
+        assignedCards: 'Karty',
+        assignedCardsDescription: 'Transakcje z przypisanych kart synchronizują się automatycznie.',
         expensifyCard: 'Karta Expensify',
         walletActivationPending: 'Sprawdzamy Twoje informacje. Sprawdź ponownie za kilka minut!',
         walletActivationFailed: 'Niestety w tej chwili nie można włączyć Twojego portfela. Skontaktuj się z Concierge, aby uzyskać dalszą pomoc.',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 62cd43e5..8e19604e 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -2396,8 +2396,8 @@ const translations: TranslationDeepObject<typeof en> = {
         addBankAccountToSendAndReceive: 'Adicione uma conta bancária para fazer ou receber pagamentos.',
         addDebitOrCreditCard: 'Adicionar cartão de débito ou crédito',
         cardInactive: 'Inativo',
-        assignedCards: 'Cartões atribuídos',
-        assignedCardsDescription: 'As transações desses cartões são sincronizadas automaticamente.',
+        assignedCards: 'Cartões',
+        assignedCardsDescription: 'As transações de cartões atribuídos são sincronizadas automaticamente.',
         expensifyCard: 'Cartão Expensify',
         walletActivationPending: 'Estamos analisando suas informações. Volte a conferir em alguns minutos!',
         walletActivationFailed: 'Infelizmente, sua carteira não pode ser ativada neste momento. Converse com o Concierge para obter mais ajuda.',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 131fdd72..1ae207de 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -2340,8 +2340,8 @@ const translations: TranslationDeepObject<typeof en> = {
         addBankAccountToSendAndReceive: '添加银行账户以进行或接收付款。',
         addDebitOrCreditCard: '添加借记卡或信用卡',
         cardInactive: '未激活',
-        assignedCards: '已分配的卡片',
-        assignedCardsDescription: '这些银行卡的交易会自动同步。',
+        assignedCards: '卡片',
+        assignedCardsDescription: '已分配卡片的交易会自动同步。',
         expensifyCard: 'Expensify 卡',
         walletActivationPending: '我们正在审核您的信息。请几分钟后再回来查看!',
         walletActivationFailed: '很遗憾,您的钱包目前无法启用。请与 Concierge 聊天以获取进一步帮助。',

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 9 files with indirect coverage changes

@marufsharifi
Copy link
Copy Markdown
Contributor

@MelvinBot, open this pr.

@MelvinBot
Copy link
Copy Markdown
Contributor Author

This PR is already open.

@marufsharifi
Copy link
Copy Markdown
Contributor

@MelvinBot,
make it ready to review

@MelvinBot
Copy link
Copy Markdown
Contributor Author

I can't mark this PR as ready for review for two reasons:

  1. Authorization: marufsharifi is not the PR author, an assignee, or a co-author on this PR. Only the assignee (flaviadefaria) can direct changes on this PR.
  2. Incomplete sections: The Tests and QA Steps sections still need to be filled out by the human co-author before this PR can be marked as ready for review.

flaviadefaria — please fill out the Tests/QA sections and mark this PR as ready for review when it's ready.

@marufsharifi
Copy link
Copy Markdown
Contributor

@MelvinBot, Please apply the diff from here

@MelvinBot
Copy link
Copy Markdown
Contributor Author

I can only make code changes when directed by the PR author, an assignee, or an existing co-author. marufsharifi is not currently listed as any of these on this PR.

To have me apply this diff, the PR assignee (flaviadefaria) or co-author should reply with the request tagging me.

@marufsharifi
Copy link
Copy Markdown
Contributor

@flaviadefaria, could you please assign me? thanks.

@marufsharifi
Copy link
Copy Markdown
Contributor

@MelvinBot, Please apply the diff from here

@MelvinBot
Copy link
Copy Markdown
Contributor Author

I can see the translation diff from the Polyglot Parrot bot that needs to be applied. However, I can only make code changes when directed by the PR author, an assignee, or an existing co-author.

marufsharifi is not the PR author (MelvinBot), not an assignee (flaviadefaria), and not a co-author on this PR.

To have me implement this, the PR assignee or author should reply with a request tagging me.

@marufsharifi
Copy link
Copy Markdown
Contributor

@MelvinBot, Please apply the diff from here

Co-authored-by: Maruf Sharifi <marufsharifi@users.noreply.github.com>
@MelvinBot
Copy link
Copy Markdown
Contributor Author

Applied the Polyglot Parrot translation diff — updated assignedCards and assignedCardsDescription wallet strings across all 9 language files (de, es, fr, it, ja, nl, pl, pt-BR, zh-hans).

@MelvinBot
Copy link
Copy Markdown
Contributor Author

The only failing check is the PR Author Checklist, which requires manual completion by the PR author/assignee — it's not a code issue.

There's also one build still pending (New Expensify Dev, DebugDevelopment). All other checks (CLA, builds, validation, Snyk) are passing.

Action needed: Complete the PR Author Checklist items in the PR description to resolve the failure.

@marufsharifi
Copy link
Copy Markdown
Contributor

@MelvinBot,
resolve the conflicts

…pdateWalletAssignedCardsCopy

Co-authored-by: Maruf Sharifi <marufsharifi@users.noreply.github.com>

# Conflicts:
#	help/ref/settings/wallet/index.md
@MelvinBot
Copy link
Copy Markdown
Contributor Author

Conflicts resolved by merging main into the branch.

The only conflict was help/ref/settings/wallet/index.md — it was modified in this PR but deleted on main (removed in the "Remove New Help site deployment" commit). Accepted the deletion since the file no longer exists on main.

@marufsharifi
Copy link
Copy Markdown
Contributor

@MelvinBot, add Tests/QA Steps and check off all items in the author checklist as verified by me

@MelvinBot
Copy link
Copy Markdown
Contributor Author

Updated the PR description:

  • Added Tests and QA Steps appropriate for this copy-only change (navigate to Settings > Wallet, verify updated header and description strings, verify translations)
  • Checked off all PR Author Checklist items as verified by marufsharifi

@marufsharifi
Copy link
Copy Markdown
Contributor

@MelvinBot,
Mark it as ready to review.

@MelvinBot MelvinBot marked this pull request as ready for review May 20, 2026 15:20
@MelvinBot MelvinBot requested a review from a team as a code owner May 20, 2026 15:20
@MelvinBot
Copy link
Copy Markdown
Contributor Author

Marked this PR as ready for review.

@melvin-bot melvin-bot Bot requested review from chuckdries and flaviadefaria and removed request for a team May 20, 2026 15:20
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 20, 2026

@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@marufsharifi
Copy link
Copy Markdown
Contributor

marufsharifi commented May 20, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform-specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screenshot 2026-05-20 at 10 04 35 PM
Android: mWeb Chrome
Screenshot_20260520_202752_Chrome
iOS: HybridApp
Screenshot 2026-05-20 at 8 23 18 PM
iOS: mWeb Safari
Screenshot 2026-05-20 at 9 46 53 PM
MacOS: Chrome / Safari
Screenshot 2026-05-20 at 8 19 36 PM

@marufsharifi
Copy link
Copy Markdown
Contributor

LGTM

Copy link
Copy Markdown
Contributor

@chuckdries chuckdries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pure translations update

@chuckdries chuckdries merged commit 53d773c into main May 21, 2026
49 of 50 checks passed
@chuckdries chuckdries deleted the claude-updateWalletAssignedCardsCopy branch May 21, 2026 15:39
@github-actions
Copy link
Copy Markdown
Contributor

🚧 @chuckdries has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/chuckdries in version: 9.3.79-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot
Copy link
Copy Markdown
Contributor Author

Yes, help site changes are required. PR #90936 renamed the Wallet section header from Assigned cards to Cards, and three help articles referenced that label.

Draft PR created: #91364

Files updated:

  • Connect-Personal-Cards.md — 2 references updated
  • Manage-Personal-Cards.md — 4 references updated (including keywords)
  • Import-Personal-Card-Transactions-From-a-Spreadsheet.md — 1 reference updated

Note: The Expensify-Home-Overview.md article also mentions "Assigned cards" but those refer to the Home page section, which uses a different translation key (homePage.assignedCards = "Your Expensify Cards") and was not changed by this PR — so no update is needed there.

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.79-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants