fix: crash when searching results on participants step by rohit9625 · Pull Request #90918 · Expensify/App

rohit9625 · 2026-05-17T17:11:17Z

Explanation of Change

Whenever searching for participants by email at the Participants Step, the maxResults were being increased irrespective of the search results via onEndReached -> onListEndReached function. Hence, the data passed to the FlashList being updated and it results in re-rendering the list items. However, when there less results in the list, the FlashList keep executing it's onEndReached function and updating the maxResults everytime. This results, in an infinite loop and causing the crash due to repeated calls of setState function.

So, I added a gaurd to prevent increasing maxResults to load more search results when there are no more results to fetch.

Fixed Issues

$ #90533
PROPOSAL: $ #90533 (comment)

Tests

Log in with a high-traffic account
Tap on FAB -> Create Expense -> Enter Amount -> Next
At the Participants screen:
- Try searching participants by email (2-3 times)
- Scrolling the list to the end
- Make sure that more participants are loaded when reached at the end
Repeat step 4 for 1-2 minutes
Make sure the app doesn't crash while performing the above steps

Verify that no errors appear in the JS console

Offline tests

Login with a high-traffic account
Force offline
Tap on FAB -> Create Expense -> Enter Amount -> Next
At the Participants screen:
- Try searching participants by email (2-3 times)
- Scrolling the list to the end
- Make sure that more participants are loaded when reached at the end
Repeat the step 3 for 1-2 minutes
Make sure the app doesn't crash while performing above steps

Note: For reliable reproduction of the crash, please refer to my proposal before testing this PR.

QA Steps

Same as tests
// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-05-17.at.8.18.13.PM.mov

Android: mWeb Chrome

Screen.Recording.2026-05-17.at.8.25.36.PM.mov

iOS: Native

Screen.Recording.2026-05-18.at.2.16.00.PM.mov

iOS: mWeb Safari

Screen.Recording.2026-05-17.at.8.59.53.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-05-17.at.8.07.24.PM.mov

Prevent increasing maxResults to load more search results when there are no more results to fetch.

codecov · 2026-05-17T17:20:03Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/hooks/useSearchSelector/base.ts	`72.64% <62.50%> (-1.28%)`	⬇️
... and 179 files with indirect coverage changes

melvin-bot · 2026-05-18T08:50:44Z

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-05-18T08:50:50Z

@MariaHCD Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify

Damn, nice find! 👍

QichenZhu · 2026-05-19T07:54:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
The issue only happens on certain platforms on low-end devices, and I don't think unit tests can emulate that.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-05-20.at.5.33.08.PM.mov

Android: mWeb Chrome

Screen.Recording.2026-05-19.at.7.46.56.PM.mov

iOS: HybridApp

Simulator.Screen.Recording.-.iPhone.17.-.2026-05-19.at.19.31.13.mov

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.17.-.2026-05-19.at.19.34.02.mov

MacOS: Chrome / Safari

Screen.Recording.2026-05-20.at.5.31.49.PM.mov

MariaHCD · 2026-05-19T08:30:34Z

@rohit9625 could you address the merge conflict while @QichenZhu is reviewing+testing. Thanks!

rohit9625 · 2026-05-19T09:05:26Z

@rohit9625 could you address the merge conflict while @QichenZhu is reviewing+testing. Thanks!

Sure, I'm resolving the conflicts now :)

trjExpensify

Re-approving from product. 👍

QichenZhu

Thanks!

rohit9625 · 2026-05-21T14:35:06Z

Hi @MariaHCD, can we merge this now?

MariaHCD · 2026-05-21T14:37:40Z

Reviewing 👀

melvin-bot · 2026-05-21T14:56:49Z

@MariaHCD looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

github-actions · 2026-05-21T14:57:22Z

🚧 @MariaHCD has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-21T15:02:11Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #90918.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-2695f8f-fdf8a2c-5e7c0434144e798272a0ed8d1325b8e7651cca29/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-2695f8f-fdf8a2c-aa8900a6f1265a5b311c560613bdf2f375c98d72/index.html

Web 🕸️
https://90918.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-21T15:07:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-21T21:51:46Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.3.79-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-21T21:53:15Z

No help site changes are required for this PR.

This is a technical bug fix in src/hooks/useSearchSelector/base.ts that prevents an infinite loop crash when searching participants by email. It doesn't alter any user-facing features, UI labels, settings, or workflows — just adds a guard to stop maxResults from increasing when there are no more results to fetch. Nothing in App/docs/articles needs updating.

lanitochka17 · 2026-05-21T22:18:39Z

Deploy Blocker ##91366 was identified to be related to this PR.

francoisl · 2026-05-21T23:15:31Z

I prepared a revert that fixes the blocker linked above, though since this PR initially fixed a crash, I'm not sure reverting is the best option. The blocker isn't so bad in comparison.

#91373

QichenZhu · 2026-05-21T23:30:25Z

@francoisl the crash only happens under certain conditions, so the blocker seems more impactful.

Revert #90918 "fix: crash when searching results on participants step"

Revert #90918 "fix: crash when searching results on participants step" (cherry picked from commit 417e2e2) (cherry-picked to staging by mountiny)

…oading-search-results" This reverts commit 2695f8f, reversing changes made to 59d3fee.

OSBotify · 2026-05-22T22:25:41Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.79-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-05-22T22:44:35Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.3.80-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-22T22:46:43Z

No help site changes are required for this PR.

This is a code-level bug fix that adds a guard to prevent maxResults from being incremented infinitely when there are no more search results to load. It doesn't change any user-facing features, workflows, settings, or UI that would be documented on the help site.

OSBotify · 2026-05-25T22:36:46Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.81-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

rohit9625 and others added 2 commits May 17, 2026 19:03

fix: optimize loading of additional search results

47f7015

Prevent increasing maxResults to load more search results when there are no more results to fetch.

Merge branch 'Expensify:main' into fix/crash-loading-search-results

357b621

melvin-bot Bot assigned rohit9625 May 17, 2026

Merge branch 'Expensify:main' into fix/crash-loading-search-results

442b948

rohit9625 marked this pull request as ready for review May 18, 2026 08:50

rohit9625 requested review from a team as code owners May 18, 2026 08:50

melvin-bot Bot requested review from a team, QichenZhu and trjExpensify and removed request for a team May 18, 2026 08:50

melvin-bot Bot requested review from MariaHCD and removed request for a team May 18, 2026 08:50

trjExpensify previously approved these changes May 19, 2026

View reviewed changes

QichenZhu reviewed May 19, 2026

View reviewed changes

Comment thread src/hooks/useSearchSelector.base.ts Outdated

rohit9625 added 2 commits May 19, 2026 14:38

Merge branch 'main' into fix/crash-loading-search-results

9ef7f4b

fix: include self DM chat when calculating search results count

19de76a

rohit9625 dismissed trjExpensify’s stale review via 19de76a May 19, 2026 09:14

rohit9625 requested a review from trjExpensify May 19, 2026 09:38

trjExpensify previously approved these changes May 19, 2026

View reviewed changes

refactor: use type-safe map for options counters

fe9c87d

rohit9625 dismissed trjExpensify’s stale review via fe9c87d May 20, 2026 02:25

QichenZhu approved these changes May 20, 2026

View reviewed changes

MariaHCD approved these changes May 21, 2026

View reviewed changes

MariaHCD merged commit 2695f8f into Expensify:main May 21, 2026
40 of 43 checks passed

melvin-bot Bot added the Emergency label May 21, 2026

OSBotify mentioned this pull request May 21, 2026

Deploy Checklist: New Expensify 2026-05-21 #91350

Closed

MelvinBot mentioned this pull request May 21, 2026

[Due for payment 2026-06-01] [Due for payment 2026-05-29] Members - Contact list does not load when scrolled to the bottom of the list #91366

Closed

7 tasks

lanitochka17 mentioned this pull request May 21, 2026

[Due for payment 2026-06-01] [Due for payment 2026-05-29] [$250] Expense - App crashes when deleting alias text after “+” in pasted email #90533

Open

7 tasks

francoisl mentioned this pull request May 21, 2026

[CP Staging] Revert #90918 "fix: crash when searching results on participants step" #91373

Merged

52 tasks

MariaHCD added a commit that referenced this pull request May 22, 2026

Merge pull request #91373 from Expensify/francois-revert-90918

417e2e2

Revert #90918 "fix: crash when searching results on participants step"

OSBotify pushed a commit that referenced this pull request May 22, 2026

Merge pull request #91373 from Expensify/francois-revert-90918

f5801b9

Revert #90918 "fix: crash when searching results on participants step" (cherry picked from commit 417e2e2) (cherry-picked to staging by mountiny)

pull Bot pushed a commit to erickirt/expensify that referenced this pull request May 22, 2026

Revert "Merge pull request Expensify#90918 from rohit9625/fix/crash-l…

b9c42d9

…oading-search-results" This reverts commit 2695f8f, reversing changes made to 59d3fee.

Conversation

rohit9625 commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 17, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented May 18, 2026

Uh oh!

melvin-bot Bot commented May 18, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

QichenZhu commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

MariaHCD commented May 19, 2026

Uh oh!

Uh oh!

rohit9625 commented May 19, 2026

Uh oh!

trjExpensify left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

QichenZhu left a comment

Choose a reason for hiding this comment

Uh oh!

rohit9625 commented May 21, 2026

Uh oh!

MariaHCD commented May 21, 2026

Uh oh!

Uh oh!

melvin-bot Bot commented May 21, 2026

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

OSBotify commented May 21, 2026

Uh oh!

OSBotify commented May 21, 2026

Uh oh!

MelvinBot commented May 21, 2026

Uh oh!

lanitochka17 commented May 21, 2026

Uh oh!

francoisl commented May 21, 2026

Uh oh!

QichenZhu commented May 21, 2026

Uh oh!

OSBotify commented May 22, 2026

Uh oh!

OSBotify commented May 22, 2026

Uh oh!

MelvinBot commented May 22, 2026

Uh oh!

OSBotify commented May 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

rohit9625 commented May 17, 2026 •

edited

Loading

codecov Bot commented May 17, 2026 •

edited by github-actions Bot

Loading

QichenZhu commented May 19, 2026 •

edited

Loading

trjExpensify left a comment •

edited

Loading