Fix contrast: receipt placeholder + icon#90917
Conversation
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Screen.Recording.2026-05-17.at.18.54.57.mov |
dubielzyk-expensify
left a comment
There was a problem hiding this comment.
Looks great from a design perspective 👍
|
Actually. The + uses #000 as a color. Can we have it use green800 instead? |
|
@rushatgabhane can you please take a look at the comment above? Thanks |
|
Looks good |
This comment was marked as outdated.
This comment was marked as outdated.
|
@dukenv0307 fixed the svg |
|
on it now |
|
@rushatgabhane It still doesn't work on my end, even though I've deleted all content and settings. |
|
@dubielzyk-expensify could you please trigger the adhoc build and help me test it? Thanks |
|
🚧 @dubielzyk-expensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
Link to adhoc build: https://90917.pr-testing.expensify.com/ |
|
It works on the web. Could you please help me test it on Android native @dubielzyk-expensify? |
|
I'll give it a try |
|
Looks like swapping colors is possible in react native as per - https://dev.to/ajmal_hasan/how-to-dynamically-apply-colors-to-svgs-in-react-native-1ha0 @MelvinBot are we doing this? Details> Solution 1: Use currentColor The simplest way to make the color property dynamic is to replace the hardcoded color value with currentColor. The currentColor value inherits the color property passed to the component. Updated SVG: Usage in React Native: Now, the color property dynamically controls the color of the SVG. |
|
The App doesn't use the Your PR is already following the established pattern correctly: you removed the hardcoded fill from the SVG path and pass |
|
Looks like we'll have to add inline svg to have dynamic colors |
|
@rushatgabhane please let me know when it's ready for review |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-05-27.at.16.57.13.movAndroid: mWeb ChromeScreen.Recording.2026-05-20.at.10.30.32.moviOS: HybridAppScreen.Recording.2026-05-27.at.16.53.23.moviOS: mWeb SafariScreen.Recording.2026-05-20.at.10.26.58.movMacOS: Chrome / SafariScreen.Recording.2026-05-20.at.10.13.11.mov |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #77405 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |



Explanation of Change
Fixed Issues
$ #77405
PROPOSAL:
Tests
the green circle.
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-05-17.at.18.54.57.mov