[NoQA] refactor: Split `ReportActionCompose` into more compositional components to allow for separate `EditOnlyReportActionCompose` by chrispader · Pull Request #90915 · Expensify/App

chrispader · 2026-05-17T15:58:31Z

Explanation of Change

Refactors the ReportActionCompose into more compositional sub-components, to prevent the need for this isEditOnly boolean flag, which doesn't comply with React compositional best practices.

Fixed Issues

$ #90889
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2026-05-17.at.16.24.14.mov

melvin-bot · 2026-05-17T16:03:24Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-05-17T16:06:33Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/inbox/ReportScreen.tsx	`95.74% <100.00%> (ø)`
...eport/ReportActionCompose/ComposerActionButton.tsx	`100.00% <100.00%> (ø)`
.../report/ReportActionCompose/ComposerActionMenu.tsx	`91.66% <100.00%> (ø)`
...s/inbox/report/ReportActionCompose/ComposerBox.tsx	`100.00% <100.00%> (ø)`
...x/report/ReportActionCompose/ComposerContainer.tsx	`100.00% <100.00%> (ø)`
...nbox/report/ReportActionCompose/ComposerContext.ts	`95.65% <ø> (ø)`
...port/ReportActionCompose/ComposerDefaultFooter.tsx	`100.00% <100.00%> (ø)`
...ox/report/ReportActionCompose/ComposerDropZone.tsx	`100.00% <100.00%> (ø)`
...ort/ReportActionCompose/ComposerEditingButtons.tsx	`100.00% <100.00%> (ø)`
...report/ReportActionCompose/ComposerEmojiPicker.tsx	`75.00% <100.00%> (ø)`
... and 10 more
... and 7 files with indirect coverage changes

hungvu193 · 2026-05-18T11:04:31Z

Let's handle this one next deploy 😄

hungvu193 · 2026-05-18T11:04:46Z

I'm a bit under the water 😭

…-report-action-compose

joekaufmanexpensify · 2026-05-18T18:42:51Z

No product review needed

mountiny · 2026-05-19T19:19:06Z

@hungvu193 How you getting on?

hungvu193 · 2026-05-20T02:02:18Z

I'll take a look today 🫡

hungvu193 · 2026-05-20T02:02:54Z

I'll take a look today 🫡

hungvu193 · 2026-05-20T10:18:11Z

I'm definitely not against this idea. The only concern is that, we're passing reportID from component to component, it's kind of hard to chase its absolute parent sometimes. Since they are all children of ComposerProvider, do you think we should let the children use the reportID of ComposerProvider as a single source of truth?

I also thought about this before, but maybe @adhorodyski can explain why he designed the new ReportActionCompose compositional + context structure like that. We should be able to just pass the reportID to ReportActionCompose once and then re-use it in all sub-components, right?

Yeah, but since it's a stable property it's not a big deal to either pass it (kinda ugly but I did it myself :D) or share through context. I'm also not against any of these options since there's no harm in either.

so totally ok to only pass it to the context provider and read from there 👍🏼

…-report-action-compose

chrispader · 2026-05-26T09:33:22Z

@hungvu193 ready for review!

hungvu193 · 2026-05-26T14:26:33Z

Thanks! I'm on it

hungvu193 · 2026-05-26T15:04:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

hungvu193

LGTM

mountiny

Thank you!

github-actions · 2026-05-26T16:25:22Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-05-26T16:34:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-26T16:35:23Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #90915.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6a3c80832c9-73f6a85-be5531bed2d9a7a3ff072281cd4c27aaaca3d752/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6a3c808-73f6a85-535a466a6dfa2a8923e03e2a32a62bf0676dc7a7/index.html

Web 🕸️
https://90915.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mkhutornyi · 2026-05-26T17:21:06Z

+import ComposerActionMenu from './ComposerActionMenu';
+import {useComposerEditState} from './ComposerContext';
+import ComposerEditingButtons from './ComposerEditingButtons';
+
+function ComposerActionButton() {
+    const {isEditingInComposer} = useComposerEditState();
+
+    if (isEditingInComposer) {
+        return <ComposerEditingButtons />;
+    }
+    return <ComposerActionMenu />;
+}
+
+export default ComposerActionButton;


App crashes immediately on start.
import React from 'react'; is missing on this file.

mkhutornyi · 2026-05-26T17:23:50Z

Adhoc build crashes too

luacmartins · 2026-05-26T18:53:06Z

This is crashing main too. I'll put up a PR to fix it

luacmartins · 2026-05-26T18:56:15Z

PR up

mountiny · 2026-05-26T20:14:09Z

Thanks!

mountiny · 2026-05-26T20:15:17Z

@hungvu193 I see you did not include any recordings in your checklist now, please make sure to always test the changes even if its decomposition refactoring in case things like this are missed

mountiny · 2026-05-26T20:15:49Z

I imagine this probably happened during some conflict resolution later so that is unfortunate, but still

m-natarajan · 2026-05-26T20:25:04Z

@mountiny NO QA steps, OK to check off this one?

OSBotify · 2026-05-26T20:38:15Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.83-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-26T20:39:45Z

No help site changes are required for this PR.

This is a pure internal code refactor that splits ReportActionCompose into smaller compositional sub-components and removes the isEditOnly boolean flag. There are no user-facing changes — no new features, UI text changes, settings changes, or behavioral changes that would need to be reflected in the help site documentation.

@chrispader, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

chrispader · 2026-05-26T21:46:44Z

@luacmartins @mountiny Thanks for handling this while i was gone! 🙌🏼

mountiny · 2026-05-27T11:32:31Z

Yeah noQA

OSBotify · 2026-05-27T17:27:52Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.83-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

chrispader added 2 commits May 17, 2026 16:34

refactor: ReportActionCompose changes compositional approach

4e9f65d

refactor: split compositional components into separate files

0d80e6c

melvin-bot Bot assigned chrispader May 17, 2026

chrispader mentioned this pull request May 17, 2026

[CP Staging] fix: Allow editing sent messages when chat "Who can post" in chat is set to "Admins only" #90912

Merged

52 tasks

chrispader marked this pull request as ready for review May 17, 2026 16:03

chrispader requested review from a team as code owners May 17, 2026 16:03

melvin-bot Bot requested review from hungvu193 and joekaufmanexpensify and removed request for a team and hungvu193 May 17, 2026 16:03

mountiny requested review from hungvu193 and mountiny May 18, 2026 13:06

Merge branch 'main' into @chrispader/refactor/compositional-edit-only…

6a1f6f2

…-report-action-compose

joekaufmanexpensify removed their request for review May 18, 2026 18:42

hungvu193 reviewed May 20, 2026

View reviewed changes

adhorodyski reviewed May 22, 2026

View reviewed changes

Comment thread src/pages/inbox/report/ReportActionCompose/ReportActionComposeInputArea.tsx Outdated

Merge branch 'main' into @chrispader/refactor/compositional-edit-only…

4d7818b

…-report-action-compose

fix: TS errors

b4bdb34

hungvu193 approved these changes May 26, 2026

View reviewed changes

mountiny approved these changes May 26, 2026

View reviewed changes

mountiny merged commit 6a3c808 into Expensify:main May 26, 2026
40 checks passed

mkhutornyi reviewed May 26, 2026

View reviewed changes

luacmartins mentioned this pull request May 26, 2026

[No QA] Import react #91750

Merged

51 tasks

OSBotify mentioned this pull request May 26, 2026

Deploy Checklist: New Expensify 2026-05-26 #91756

Closed

54 tasks

mountiny changed the title ~~refactor: Split ReportActionCompose into more compositional components to allow for separate EditOnlyReportActionCompose~~ [NoQA] refactor: Split ReportActionCompose into more compositional components to allow for separate EditOnlyReportActionCompose May 27, 2026

melvin-bot Bot mentioned this pull request May 27, 2026

[Due for payment 2026-06-03] [Due for payment 2026-05-26] [Due for payment 2026-05-26] Unable to edit sent message in narrow screen when room posting permission is disabled #90889

Closed

7 tasks

wildan-m mentioned this pull request May 28, 2026

[$250] Chat - Composer field is cut off at the bottom when expanded #91927

Open

7 tasks

MelvinBot mentioned this pull request May 29, 2026

Compose box - When expanded all of the compose box moves to the top #92038

Open

7 tasks

mountiny mentioned this pull request May 30, 2026

[No QA] Revert #90915, #91750 and #90365 (composer refactor + enable-notifications banner) #92134

Closed

51 tasks

Conversation

chrispader commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 17, 2026

Uh oh!

codecov Bot commented May 17, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hungvu193 commented May 18, 2026

Uh oh!

hungvu193 commented May 18, 2026

Uh oh!

joekaufmanexpensify commented May 18, 2026

Uh oh!

mountiny commented May 19, 2026

Uh oh!

hungvu193 commented May 20, 2026

Uh oh!

hungvu193 commented May 20, 2026

Uh oh!

hungvu193 May 20, 2026

Choose a reason for hiding this comment

Uh oh!

chrispader May 22, 2026

Choose a reason for hiding this comment

Uh oh!

adhorodyski May 22, 2026

Choose a reason for hiding this comment

Uh oh!

adhorodyski May 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chrispader commented May 26, 2026

Uh oh!

hungvu193 commented May 26, 2026

Uh oh!

hungvu193 commented May 26, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented May 26, 2026

Uh oh!

OSBotify commented May 26, 2026

Uh oh!

github-actions Bot commented May 26, 2026

Uh oh!

mkhutornyi May 26, 2026

Choose a reason for hiding this comment

Uh oh!

mkhutornyi commented May 26, 2026

Uh oh!

luacmartins commented May 26, 2026

Uh oh!

luacmartins commented May 26, 2026

Uh oh!

mountiny commented May 26, 2026

Uh oh!

mountiny commented May 26, 2026

Uh oh!

mountiny commented May 26, 2026

Uh oh!

m-natarajan commented May 26, 2026

Uh oh!

chrispader commented May 17, 2026 •

edited

Loading

codecov Bot commented May 17, 2026 •

edited by github-actions Bot

Loading

chrispader commented May 26, 2026 •

edited

Loading