Conversation
CitralFlo
commented
Aug 26, 2026
CitralFlo
commented
Member
CitralFlo
changed the title
P1otrulla
approved these changes
Aug 27, 2026
P1otrulla
left a comment
P1otrulla
left a comment
Member
There was a problem hiding this comment.
Bardzo dobra robota! 💯
Zastanawiam się tylko czy nie powinniśmy przenieść tego Interface'a do api (review z tel 👀)
Member
Author
Juz jest 🫡 Jeśli coś innego to prośba o doprecyzowanie |
Jakubk15
requested changes
Aug 27, 2026
| * Checks if a player is ignored for mob targeting. | ||
| * @return true if the player is ignored, false otherwise. | ||
| */ | ||
| boolean doMobsIgnore(UUID uniqueId); |
Member
There was a problem hiding this comment.
Suggested change
| boolean doMobsIgnore(UUID uniqueId); | |
| boolean isIgnored(UUID player); |
Member
There was a problem hiding this comment.
i suggested isIgnored because the "mobs" part is already in class name and i don't think we should duplicate it.
| @Accessors(fluent = true) | ||
| public class PLNoTargetMessages extends OkaeriConfig implements NoTargetMessages { | ||
| Notice disabled = Notice.chat("<color:#9d6eef>► <white>Potwory nie będą Cię więcej ignorować!"); | ||
| Notice enabled = Notice.chat("<color:#9d6eef>► <white>Potwory będą Cię ignorować!"); |
Member
There was a problem hiding this comment.
Suggested change
| Notice enabled = Notice.chat("<color:#9d6eef>► <white>Potwory będą Cię ignorować!"); | |
| Notice enabled = Notice.chat("<color:#9d6eef>► <white>Potwory będą cię ignorować!"); |
| @Getter | ||
| @Accessors(fluent = true) | ||
| public class PLNoTargetMessages extends OkaeriConfig implements NoTargetMessages { | ||
| Notice disabled = Notice.chat("<color:#9d6eef>► <white>Potwory nie będą Cię więcej ignorować!"); |
Member
There was a problem hiding this comment.
Suggested change
| Notice disabled = Notice.chat("<color:#9d6eef>► <white>Potwory nie będą Cię więcej ignorować!"); | |
| Notice disabled = Notice.chat("<color:#9d6eef>► <white>Potwory nie będą cię więcej ignorować!"); |
Jakubk15
approved these changes
Sep 4, 2026
| private final HashSet<UUID> mobTargetMap = new HashSet<>(); | ||
|
|
||
| @Override | ||
| public void removeTracking(Player player) { |
Member
There was a problem hiding this comment.
stopTracking would be better imo because we have startTracking so these names naturally compliment themselves
| * Checks if a player is ignored for mob targeting. | ||
| * @return true if the player is ignored, false otherwise. | ||
| */ | ||
| boolean doMobsIgnore(UUID uniqueId); |
Member
There was a problem hiding this comment.
i suggested isIgnored because the "mobs" part is already in class name and i don't think we should duplicate it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.