GH-1330 Accept latest teleport request if no player specified - #1408
Open
Pawelusze wants to merge 3 commits into
Open
GH-1330 Accept latest teleport request if no player specified#1408Pawelusze wants to merge 3 commits into
Pawelusze wants to merge 3 commits into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Pawelusze
assigned
vLuckyyy,
Jakubk15,
CitralFlo,
ChudziudgiToJa and
P1otrulla and unassigned
vLuckyyy,
Jakubk15,
P1otrulla,
CitralFlo,
ChudziudgiToJa and
Pawelusze
Pawelusze
requested review from
ChudziudgiToJa,
CitralFlo,
Jakubk15,
P1otrulla,
imDMK and
vLuckyyy
July 27, 2026 15:12
CitralFlo
requested changes
Jul 30, 2026
Jakubk15
approved these changes
Aug 6, 2026
| void acceptLatest(@Sender Player player) { | ||
| Player target = this.requestService.findRequests(player.getUniqueId()).stream() | ||
| .map(this.server::getPlayer) | ||
| .filter(Objects::nonNull) |
Member
There was a problem hiding this comment.
Suggested change
| .filter(Objects::nonNull) |
I think we can remove this line, we don't need that aggressive null-safety and we never put null as a request
| void executeLatest(@Sender Player player) { | ||
| Player target = this.requestService.findRequests(player.getUniqueId()).stream() | ||
| .map(this.server::getPlayer) | ||
| .filter(Objects::nonNull) |
Member
There was a problem hiding this comment.
Suggested change
| .filter(Objects::nonNull) |
as above
CitralFlo
requested changes
Sep 6, 2026
CitralFlo
approved these changes
Sep 6, 2026
imDMK
requested changes
Sep 7, 2026
| .toList(); | ||
| } | ||
|
|
||
| private record Request(UUID target, Instant createdAt) {} |
Contributor
There was a problem hiding this comment.
w TeleportHereRequestService tworzyliśmy już taki rekord - do wydzielenia z tych klas
Member
|
@Pawelusze can we make this whole feature configurable? you can make a key like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a player runs /tpaccept or /tpahereaccept without arguments, it automatically accepts their most recent pending teleport request