Skip to content

Apply buildifier linter suggestions#196

Open
furtib wants to merge 8 commits intoEricsson:mainfrom
furtib:bazel-liter-suggestions
Open

Apply buildifier linter suggestions#196
furtib wants to merge 8 commits intoEricsson:mainfrom
furtib:bazel-liter-suggestions

Conversation

@furtib
Copy link
Contributor

@furtib furtib commented Feb 23, 2026

Why:
We want to produce high quality bazel code. To do this, we use buildifier to both format and lint our files.

What:

  • Applied all* linter suggestions to bzl files

*: In per_file.bzl in the run_code_checker function I puposefully ignored the unused variable errors. This function is still in early development, and the unused variables (arguments, label, env_vars, compilation_context) may be necessary in the future.

Addresses:
#155

@furtib furtib requested a review from Szelethus February 23, 2026 09:08
@furtib furtib self-assigned this Feb 23, 2026
@furtib furtib added the non-functional change ☮️ The patch doesn't change any functionality, e.g. refactoring, documentation, test-only. label Feb 23, 2026
@furtib
Copy link
Contributor Author

furtib commented Feb 23, 2026

Note:
You might notice that the ctx argument is documented over and over again, despite its obvious meaning.
This documentation step can be avoided if we rename the variable to _ctx.
What are your thoughts on this?

@furtib furtib force-pushed the bazel-liter-suggestions branch from 8e9b876 to a59b65b Compare February 23, 2026 09:25
@furtib furtib changed the title Apply buildifier liter suggestions Apply buildifier linter suggestions Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

non-functional change ☮️ The patch doesn't change any functionality, e.g. refactoring, documentation, test-only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant