Don't fail component parsing on unparseable hex colors - #3029
Merged
octylFractal merged 2 commits intoOct 2, 2026
Merged
Conversation
Vanilla text components may carry hex colors (#RRGGBB) since 1.16, which text3 cannot represent. The old TextColorWrapper deserialization threw JsonParseException and the whole component parse failed. This drops the unparseable color instead, keeping the text content. Named colors still parse as before.
Addresses review feedback on EngineHub#3029: keep the parse-failure stacktrace available at debug level, and add the GPL header to the new test class.
fbrandt-dev
force-pushed
the
fix/hex-color-drop
branch
from
October 2, 2026 23:00
90ea2e4 to
ce8dcaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vanilla text components may carry hex colors (
#RRGGBB) since 1.16, which text3 cannot represent. Deserializing such a component threwJsonParseExceptionand failed parsing the whole component (e.g. item names viagetRichItemName).This drops the unparseable color instead, keeping the text content. Named colors still parse as before.