Skip to content

Make LogBox configurable #6007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j0ntz wants to merge 1 commit into
base: develop
Choose a base branch
from
+12 −6
Open

Make LogBox configurable #6007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased (develop)

- added: Logbox disable option to env.json

## 4.49.0 (staging)

- added: Honor `af` affiliate parameter on `deep.edge.app` deep links, activating the promotion alongside any inner payload (e.g. private-key import).
Expand Down
13 changes: 8 additions & 5 deletions src/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,14 @@ if (ENV.SENTRY_ORGANIZATION_SLUG.includes('SENTRY_ORGANIZATION')) {
}

// Uncomment the next line to remove popup warning/error boxes.
// LogBox.ignoreAllLogs()
LogBox.ignoreLogs([
'Require cycle:',
'Attempted to end a Span which has already ended.'
])
if (ENV.LOGBOX_DISABLE) {
Copy link
Copy Markdown

@cursor cursor Bot Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment no longer matches code behavior

Low Severity

The comment "Uncomment the next line to remove popup warning/error boxes." is now stale — there is no longer a commented-out line to uncomment. The behavior is instead controlled by ENV.LOGBOX_DISABLE. This violates the remove-stale-comments rule: comments that no longer match reality need to be updated or removed.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 4671def. Configure here.

LogBox.ignoreAllLogs()
} else {
LogBox.ignoreLogs([
'Require cycle:',
'Attempted to end a Span which has already ended.'
])
}

// Mute specific console output types.
// Useful for debugging using console output, i.e. mute everything but `debug`
Expand Down
3 changes: 2 additions & 1 deletion src/envConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,5 +558,6 @@ export const asEnvConfig = asObject({
overrideThemeFile: '/Users/username/Documents/overrideTheme.json'
}
),
EXPERIMENT_CONFIG_OVERRIDE: asOptional(asObject(asString), {})
EXPERIMENT_CONFIG_OVERRIDE: asOptional(asObject(asString), {}),
LOGBOX_DISABLE: asOptional(asBoolean, false)
}).withRest
Loading