Skip to content

Set Pic ID: Add better visualisation and more edge cases - #46

Open
Ghabry wants to merge 1 commit into
EasyRPG:masterfrom
Ghabry:change-pic-id
Open

Set Pic ID: Add better visualisation and more edge cases#46
Ghabry wants to merge 1 commit into
EasyRPG:masterfrom
Ghabry:change-pic-id

Conversation

@Ghabry

@Ghabry Ghabry commented Sep 1, 2026

Copy link
Copy Markdown
Member

(overlap + partially incorrect IDs)

grafik grafik

(also notice the render order when looking at the 5 above the blue line)

@Mimigris

Mimigris commented Sep 1, 2026

Copy link
Copy Markdown
Contributor
  • The text of the events at (4, 1), (5, 1) (8, 1), (9, 1) are incorrect: the text interprets the size of the array as if it was bigger by 1
  • The event at (13, 1) mentions a slide of the pictures 3 ~ 4, but actually slides the IDs 4 ~ 5, which leads to an overlap with the IDs 5 ~ 6 previously edited by the same event

@Ghabry

Ghabry commented Sep 1, 2026

Copy link
Copy Markdown
Member Author

wow I cannot count. Fixed thanks

@Mimigris

Mimigris commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Looks good to me, should be able to be merged 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants