fix: native callbacks and scoped npm publishing - #1
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
DragonWork
added a commit
that referenced
this pull request
Sep 10, 2026
Native callback fixes and scoped npm publishing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring the Unix and Windows callback fixes into this fork, preserving Azq2's original commit.
Prepare
@dragonwork/serialport-bindings-cpp@13.0.1-patch.1with rebuilt native binaries. Manual workflow runs only create a package artifact; GitHub releases publish through npm trusted publishing.fix/windows-async-callbacksand upstream serialport#243 stay untouched.Checked locally on Linux arm64 / Node 26.8.2: build, typecheck, ESLint, workflow lint, package loading and 74 existing tests pass (2 skipped; Node type stripping disabled for the test runner). Cross-platform builds still need a workflow run. No new tests.