Enable configuring the health check from install.#159
Closed
naturedamends wants to merge 1 commit intoDokploy:mainfrom
Closed
Enable configuring the health check from install.#159naturedamends wants to merge 1 commit intoDokploy:mainfrom
naturedamends wants to merge 1 commit intoDokploy:mainfrom
Conversation
3d4000b to
a7e3ae2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am trying to reduce idle CPU usage. Dokpoly is using 2 percent ish on my low powered device.
I'm not bothered about delth checks
this allows keeping them, turning them off, and configuring the values
Greptile Summary
This PR adds
HEALTH_CMD,HEALTH_INTERVAL,HEALTH_TIMEOUT,HEALTH_RETRIES, andHEALTH_START_PERIODenvironment-variable overrides for the Traefik container's health check, and correctly handlesHEALTH_CMD=nonevia Docker's--no-healthcheckflag. The HEALTH_CMD=none fix from the previous review round is now properly implemented.Two unresolved concerns carry over: the word-splitting bug when health-check values contain spaces (e.g.
HEALTH_CMD=\"curl -f http://localhost/\"— single-quotes embedded in an unquoted variable expansion are treated literally, not as shell quoting) and the new finding that combiningHEALTH_CMD=nonewith any of the interval/timeout/retries/start-period variables passes both--no-healthcheckand a--health-*flag to Docker, which Docker rejects outright.Confidence Score: 4/5
Not ready to merge — an existing P1 word-splitting bug is unresolved and a new edge-case conflict can prevent Traefik from starting.
The HEALTH_CMD=none fix is now correct. However, the P1 word-splitting issue flagged in the previous review round remains unaddressed (single-quoted values inside an unquoted $HEALTH_EXTRA_OPTS are not protected from word splitting, so multi-word health-cmd values are mis-parsed). Additionally, a new bug exists where combining HEALTH_CMD=none with any of the interval/timeout/retries/start-period variables produces a docker command Docker refuses to execute.
apps/website/public/install.sh — specifically the HEALTH_EXTRA_OPTS construction and its unquoted expansion in the docker run call.
Comments Outside Diff (1)
apps/website/public/install.sh, line 292-306 (link)The
docker service createblock for the maindokployservice (lines 272–288) does not receive any of the newHEALTH_*variables. If the motivation is reducing idle CPU caused by health probes, thedokployservice is also a candidate. This may be intentional, but it is worth documenting or extending the feature to be consistent.Reviews (2): Last reviewed commit: "Fix as per AI, plus add sh compatibility..." | Re-trigger Greptile