feat: Add Seanime and remove strapai duplicate entry#808
feat: Add Seanime and remove strapai duplicate entry#808EnnioMrk wants to merge 11 commits intoDokploy:canaryfrom
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds a new Dokploy blueprint for deploying Seanime and registers it in the template index.
Changes:
- Added a new
blueprints/seanime/template (Compose + Dokploytemplate.toml+ logo). - Added a
meta.jsonentry for the newseanimetemplate.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| meta.json | Registers the new seanime template in the central catalog. |
| blueprints/seanime/docker-compose.yml | Defines the Seanime service (plus an init step) and persistent mounts. |
| blueprints/seanime/template.toml | Declares the domain mapping and Dokploy config for the blueprint. |
| blueprints/seanime/seanime.png | Adds the template logo asset referenced by meta.json. |
Comments suppressed due to low confidence (1)
blueprints/seanime/template.toml:13
config.mountsis declared but the mount entry is empty; the template validator requires each mount to include at leastfilePath(string) andcontent(string). Either remove the[[config.mounts]]section entirely or fill in the required fields so validation passes.
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@greptileai The deletion of strapi was intentional because it was duplicate. |
|
Based on the diff, only one If the duplicate was in a different JSON structure or a previous state of the file that predates this branch, that context isn't visible here. But from what I can see in this diff, removing the only strapi entry would cause Strapi to disappear from the template catalog entirely — which seems unintentional regardless of the motivation. Could you point to where the duplicate entry is? If there are genuinely two strapi entries somewhere in the file, I'm happy to accept the correction.
|
|
@greptileai The Diff only shows the deletion. The duplicate entry was already present. |
|
You're right, and I apologize for the false alarm. The I'll withdraw that blocker. The PR looks good to merge. Tip: You can give me more context with .greptile/rules so I get this right next time. |
|
@greptileai update the original pr message to reflect this |
|
Looks like I don't have permission to update the PR directly. Here's the updated description you can paste in yourself: What is this PR about?New PR to add Seanime — a self-hosted anime streaming template. All prior review findings have been resolved (pinned image, Remaining BlockerThe ChecklistBefore submitting this PR, please make sure that:
Screenshots or Videos(keep your existing screenshot tag) |
What is this PR about?
Add Seanime and remove the strapai duplicate entry
Checklist
Before submitting this PR, please make sure that:
Screenshots or Videos
Greptile Summary
This PR adds a new Seanime blueprint and removes a duplicate
strapientry frommeta.json. All previously flagged concerns (missingversion: "3.8", unpinned images, missingexposedirective, empty[[config.mounts]]block, andversion: "latest"in meta.json) have been addressed. The only remaining nit is that theversionfield inmeta.jsonis3.6.1-rootlesswhile the actual image tag isv3.6.1-rootless.Confidence Score: 5/5
Safe to merge — all prior blocking concerns have been resolved and only a trivial style nit remains.
All P0/P1 findings from previous review rounds are now fixed: images are pinned, the expose directive is present, version: 3.8 is declared, and the empty mounts block is gone. The only remaining finding is a missing v prefix in the meta.json version field, which is P2 and does not block merge.
No files require special attention.
Comments Outside Diff (1)
blueprints/seanime/template.toml, line 13 (link)[[config.mounts]]blockThe
[[config.mounts]]table array is declared but contains no fields. This may cause a TOML parse error or create a null/empty mount entry at deploy time. If no custom mounts are needed, remove this section entirely.meta.json, line 5969-5985 (link)strapientryThe
strapitemplate entry has been deleted frommeta.jsonin this PR, even though the PR only intends to add Seanime. This looks like an accidental deletion caused by a rebase/merge conflict. Thestrapientry should be restored.Reviews (5): Last reviewed commit: "v1.0.6" | Re-trigger Greptile
Context used: