make encoding compliant with rfc 2047#228
Open
Awlexus wants to merge 2 commits intoDockYard:masterfrom
Open
Conversation
Member
|
@andrewtimberlake thoughts? We've pushed back against strict spec RFC compliance in the interest of usability but it's your call |
Author
|
I've added a new commit to handle encoding characters like With regards to usability, how exactly would stricter compliance with the RFC hinder usability? These changes only affect the renderer, so I hope that aside from the output being changed to be more esoteric, should not change how developers use the API and make it more compatible when seen with email clients. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #227 .
Changes proposed in this pull request
This change fixes 2 violations of RFC2047:
") are not allowed in encoded words