Feature/more appearance#2292
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c8401f9df7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| compatLinkPreview: false, | ||
| showNumbers: true, | ||
| postActionStyle: 'LeftAligned', | ||
| postActionFixedWidth: true, |
There was a problem hiding this comment.
Adding this field to the /tabs fallback is not enough for persistence: the web tab editor's EditForm/GroupForm state and the updateTabPresentation/buildGroupItem calls still have no postActionFixedWidth argument, and HomeTabSettingsPresenter.buildAppearancePatch never sets AppearanceKeys.PostActionFixedWidth. When a tab with this per-tab override created on Android/iOS/desktop is edited and saved in /tabs, the rebuilt appearance patch drops the override and silently reverts the tab to the global value.
Useful? React with 👍 / 👎.
| public object LimitMediaGridToNine : PerTimeline<Boolean>( | ||
| "timeline.limit_media_grid_to_nine", | ||
| true, | ||
| Boolean.serializer(), | ||
| ) |
There was a problem hiding this comment.
This new per-timeline setting can now be saved as false, but the web timeline still hard-caps media rendering with media.slice(0, 9) and Math.min(media.length, 9) in PostMediaGrid.svelte. Users who disable the limit on another platform will still only see the first nine attachments on web for posts with 10+ media items, so the shared setting is ignored in that environment.
Useful? React with 👍 / 👎.
1 participant
No description provided.