Skip to content

Stop workflows - #1668

Merged
Oli-Jones475 merged 2 commits into
mainfrom
stop-workflows
Sep 30, 2026
Merged

Oli-Jones475 merged 2 commits into
mainfrom
stop-workflows

Conversation

@Oli-Jones475

Copy link
Copy Markdown
Contributor

Add graph endpoint that allows users to stop workflows
Users may only stop workflows they own
Jira ticket: https://jira.diamond.ac.uk/secure/RapidBoard.jspa?rapidView=2358&view=detail&selectedIssue=AP-1280#

@JamesDoingStuff JamesDoingStuff left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out locally and it works well, nice job :) Just a few optional comments in the code, but otherwise looks good 👍 Would also be good if you could squash the commits down into just 1 or 2 (one feat and one test maybe?)

Comment thread backend/graph-proxy/src/graphql/workflows.rs Outdated
Comment thread backend/graph-proxy/src/graphql/workflows.rs Outdated
Comment thread backend/graph-proxy/src/graphql/workflows.rs Outdated
Comment thread backend/graph-proxy/src/graphql/workflows.rs Outdated
Comment thread backend/graph-proxy/src/graphql/workflows.rs Outdated
Comment thread backend/graph-proxy/src/graphql/mod.rs
@Oli-Jones475
Oli-Jones475 force-pushed the stop-workflows branch 2 times, most recently from a6125e5 to bd5a132 Compare September 30, 2026 10:22
feat(graph-proxy): add function to generate more complex tokens

Function was stolen from tests module in triggers
Its a more general version
That function could not be imported because it is private

chore(graph-proxy): create happy path test for stopping workflow

fix(graph-proxy): tidy stop workflow error messages

chore(graph-proxy): add error tests for stop workflows
@Oli-Jones475
Oli-Jones475 merged commit 931dc95 into main Sep 30, 2026
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants