Skip to content

Update coordinates of existing lamella GridSquare entries when atlas image is updated - #909

Merged
tieneupin merged 6 commits into
mainfrom
update-lamella-grid-square
Oct 7, 2026
Merged

tieneupin merged 6 commits into
mainfrom
update-lamella-grid-square

Conversation

@tieneupin

@tieneupin tieneupin commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

This PR adds logic so that, when a new atlas is registered, any pre-existing GridSquare entries will have their atlas image coordinates updated to reflect their location on the newest image.

Large parts of the GridSquare registration/updating logic are shared between the atlas and lamella image registration workflows, so it was broken out into a shared function called populate_fib_grid_square_entry in murfey.workflows.fib.shared.

The actual diff is about +260/-150, with the rest of the diff being due to the addition and updating of tests to account for the new workflow behaviour.

@codecov

codecov Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.81250% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.47%. Comparing base (cc9def2) to head (83dd816).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #909      +/-   ##
==========================================
+ Coverage   55.42%   55.47%   +0.05%     
==========================================
  Files         103      103              
  Lines       11546    11571      +25     
  Branches     1541     1545       +4     
==========================================
+ Hits         6399     6419      +20     
- Misses       4800     4803       +3     
- Partials      347      349       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin
tieneupin marked this pull request as ready for review October 6, 2026 10:46
@tieneupin tieneupin self-assigned this Oct 6, 2026
@tieneupin tieneupin added server Relates to the server component fib Part of the FIB pipeline extension enhancement New feature or request labels Oct 6, 2026

@stephen-riggs stephen-riggs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I can't see any issues

@tieneupin
tieneupin merged commit 2f6906d into main Oct 7, 2026
14 checks passed
@tieneupin
tieneupin deleted the update-lamella-grid-square branch October 7, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request fib Part of the FIB pipeline extension server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants