I15-1: Add standards puck - #206
Merged
Merged
Conversation
jacob-williamson
changed the title
DominicOram
approved these changes
Sep 30, 2026
DominicOram
left a comment
DominicOram
left a comment
Collaborator
There was a problem hiding this comment.
Great, thanks. Couple of small bits, take them or leave them
|
|
||
| pins: dict[int, StandardsPin | None] | ||
|
|
||
| def get_pin_number(self, pin: StandardsPin): |
Collaborator
There was a problem hiding this comment.
Nit: I think maybe get_position_of_pin might be a bit more expressive than just number, but not a big deal
| [ | ||
| {}, | ||
| {1: None, 22: None}, | ||
| { |
Collaborator
There was a problem hiding this comment.
Nit: Can you add a comment here along the lines of # Check when more pins defined than expected
jacob-williamson
force-pushed
the
i15_1_standards_puck
branch
from
September 30, 2026 14:36
040f60a to
92e888a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for DiamondLightSource/daq-queuing-service#120