fix(api): scope workspace search to visible projects and pages

[cavidelizade]

Summary

Workspace search authorized only workspace membership and filtered the SQL by workspace_id, so a plain member (or guest) got back issues, cycles, modules, views and names from secret projects they weren't on, plus the titles of other users' private pages.

Linked issues

Closes #324

Type of change

• Bug fix (fix:)

Surface

• API (apps/api/)

What changed

• Added projectVisibleClause: a project is visible when it's public, the caller is a member of it, or the caller is a workspace admin/owner. This mirrors the gate in ProjectService.GetByID. Applied it to every project-joined search query (issues, epics, cycles, modules, views, projects).
• Restricted page hits to public pages or ones the caller owns.
• Threaded userID from the service into the store Search.

Test plan

• go build, go vet, go test ./... green, including TestSearchRespectsProjectVisibility (a non-member can't find a secret project's issue or the project itself; a member can)

Note

This is a separate path from the sub-resource fix in #319, which is why it needed its own change. The private-page-title leak isn't about secret projects at all and is fixed by the page access/owner filter.

AI assistance

• AI tools were used, tool(s): Claude Code (Opus 4.8), commits carry a Co-Authored-By: trailer

[coderabbitai]

Warning

Review limit reached

@cavidelizade, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 45 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d4f089fd-a169-4833-958e-3b098ebd2c96

📥 Commits

Reviewing files that changed from the base of the PR and between 61bc903 and 91554e4.

📒 Files selected for processing (3)

• apps/api/internal/service/search.go
• apps/api/internal/service/search_visibility_test.go
• apps/api/internal/store/search.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}