Skip to content

Map: OSM provider — Synchronize viewport and interactions - #34951

Merged
AlisherAmonulloev merged 11 commits into
feature/26_2_osm-provider-for-dxmap/mainfrom
feature/26_2_osm-provider-for-dxmap/viewport-and-interactions
Aug 28, 2026
Merged

Map: OSM provider — Synchronize viewport and interactions#34951
AlisherAmonulloev merged 11 commits into
feature/26_2_osm-provider-for-dxmap/mainfrom
feature/26_2_osm-provider-for-dxmap/viewport-and-interactions

Conversation

@AlisherAmonulloev

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Synchronizes OSM/OpenLayers viewport state, interactions, focus, controls, and disabled behavior with dxMap options.

Changes:

  • Adds bidirectional viewport and click-event synchronization.
  • Supports bounds fitting, projections, controls, focus, and disabled state.
  • Expands OSM tests and Storybook controls.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
osmTests.js Expands OSM integration coverage.
openLayersMock.js Models projections, events, controls, and interactions.
openlayers.register.js Registers additional OpenLayers APIs.
provider.ts Adds the provider focus-update hook.
provider.dynamic.osm.ts Synchronizes widget and engine state.
provider.dynamic.osm.openlayers.ts Implements OpenLayers viewport and interaction behavior.
provider.dynamic.osm.engine.ts Extends the map-engine contract.
map.ts Queues focus-option updates.
OSMMap.stories.tsx Adds interactive OSM Storybook controls.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

@AlisherAmonulloev
AlisherAmonulloev marked this pull request as ready for review August 27, 2026 12:23
@AlisherAmonulloev
AlisherAmonulloev requested a review from a team as a code owner August 27, 2026 12:23
Comment thread packages/devextreme/js/__internal/ui/map/provider.dynamic.osm.openlayers.ts Outdated
Comment thread packages/devextreme/js/__internal/ui/map/provider.dynamic.osm.openlayers.ts Outdated
Comment thread packages/devextreme/js/__internal/ui/map/provider.dynamic.osm.openlayers.ts Outdated
Comment thread packages/devextreme/testing/tests/DevExpress.ui.widgets/mapParts/osmTests.js Outdated
Comment thread packages/devextreme/js/__internal/ui/map/provider.dynamic.osm.openlayers.ts Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Suppressed comments (1)

packages/devextreme/js/__internal/ui/map/provider.dynamic.osm.openlayers.ts:174

  • This unconditionally deletes the target's current tabindex. If the target had a client-provided value, or its value was changed after initialization, disposing/repainting the engine loses that state; the previous implementation deliberately removed only an unchanged engine-owned tabindex. Preserve the original value/ownership and restore or remove it only when the engine still owns the attribute.
    this._container.removeAttribute('tabindex');

Comment thread packages/devextreme/js/__internal/ui/map/provider.dynamic.osm.openlayers.ts Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.

@AlisherAmonulloev
AlisherAmonulloev merged commit b83e180 into feature/26_2_osm-provider-for-dxmap/main Aug 28, 2026
100 checks passed
@AlisherAmonulloev
AlisherAmonulloev deleted the feature/26_2_osm-provider-for-dxmap/viewport-and-interactions branch August 28, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants