Map: OSM provider — Synchronize viewport and interactions - #34951
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Synchronizes OSM/OpenLayers viewport state, interactions, focus, controls, and disabled behavior with dxMap options.
Changes:
- Adds bidirectional viewport and click-event synchronization.
- Supports bounds fitting, projections, controls, focus, and disabled state.
- Expands OSM tests and Storybook controls.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
osmTests.js |
Expands OSM integration coverage. |
openLayersMock.js |
Models projections, events, controls, and interactions. |
openlayers.register.js |
Registers additional OpenLayers APIs. |
provider.ts |
Adds the provider focus-update hook. |
provider.dynamic.osm.ts |
Synchronizes widget and engine state. |
provider.dynamic.osm.openlayers.ts |
Implements OpenLayers viewport and interaction behavior. |
provider.dynamic.osm.engine.ts |
Extends the map-engine contract. |
map.ts |
Queues focus-option updates. |
OSMMap.stories.tsx |
Adds interactive OSM Storybook controls. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
AlisherAmonulloev
marked this pull request as ready for review
August 27, 2026 12:23
Raushen
reviewed
Aug 28, 2026
Raushen
reviewed
Aug 28, 2026
Raushen
reviewed
Aug 28, 2026
Raushen
reviewed
Aug 28, 2026
Raushen
reviewed
Aug 28, 2026
Raushen
reviewed
Aug 28, 2026
Raushen
reviewed
Aug 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
packages/devextreme/js/__internal/ui/map/provider.dynamic.osm.openlayers.ts:174
- This unconditionally deletes the target's current
tabindex. If the target had a client-provided value, or its value was changed after initialization, disposing/repainting the engine loses that state; the previous implementation deliberately removed only an unchanged engine-owned tabindex. Preserve the original value/ownership and restore or remove it only when the engine still owns the attribute.
this._container.removeAttribute('tabindex');
AlisherAmonulloev
requested review from
Raushen
and
a balanced review from Copilot
August 28, 2026 15:01
Raushen
approved these changes
Aug 28, 2026
AlisherAmonulloev
merged commit Aug 28, 2026
b83e180
into
feature/26_2_osm-provider-for-dxmap/main
100 checks passed
AlisherAmonulloev
deleted the
feature/26_2_osm-provider-for-dxmap/viewport-and-interactions
branch
August 28, 2026 15:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.