Skip to content

GridCore data: Relocate _editingController to editing data-extenders (virtual scrolling) #34875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bit-byte0 merged 2 commits into from
Aug 25, 2026
Merged

GridCore data: Relocate _editingController to editing data-extenders (virtual scrolling) #34875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c7cc3e
refactor(grids): split virtualScrolling module and define editingCont…
bit-byte0 Aug 24, 2026
66ec03e
refactor(grids): address review feedback on virtualScrolling split
bit-byte0 Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/devextreme/js/__internal/grids/data_grid/module_not_extended/virtual_scrolling.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { dataSourceAdapterExtender, virtualScrollingModule } from '@ts/grids/grid_core/virtual_scrolling/m_virtual_scrolling';
import { dataSourceAdapterExtender, virtualScrollingModule } from '@ts/grids/grid_core/virtual_scrolling/index';

import gridCore from '../m_core';
import dataSourceAdapterProvider from '../m_data_source_adapter';
Expand Down
2 changes: 1 addition & 1 deletion ...ges/devextreme/js/__internal/grids/grid_core/keyboard_navigation/m_keyboard_navigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import type { RowIndexCorrection } from '@ts/grids/grid_core/data_controller/typ
import type { EditingController } from '@ts/grids/grid_core/editing/m_editing';
import type { RowsView } from '@ts/grids/grid_core/views/m_rows_view';
import type { RowsViewScrollEvent } from '@ts/grids/grid_core/views/types';
import type { VirtualScrollingDataControllerExtension } from '@ts/grids/grid_core/virtual_scrolling/m_virtual_scrolling';
import type { VirtualScrollingDataControllerExtension } from '@ts/grids/grid_core/virtual_scrolling/index';
import { memoize } from '@ts/utils/memoize';

import {
Expand Down
17 changes: 17 additions & 0 deletions packages/devextreme/js/__internal/grids/grid_core/virtual_scrolling/const.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
export const BOTTOM_LOAD_PANEL_CLASS = 'bottom-load-panel';
export const GROUP_SPACE_CLASS = 'group-space';
export const FREESPACE_CLASS = 'dx-freespace-row';
export const COLUMN_LINES_CLASS = 'dx-column-lines';
export const VIRTUAL_ROW_CLASS = 'dx-virtual-row';
export const ROW_INSERTED = 'dx-row-inserted';

export const SCROLLING_MODE_INFINITE = 'infinite';
export const SCROLLING_MODE_VIRTUAL = 'virtual';
export const LOAD_TIMEOUT = 300;
export const LEGACY_SCROLLING_MODE = 'scrolling.legacyMode';
export const VISIBLE_PAGE_INDEX = 'paging.pageIndex';
export const PAGING_METHOD_NAMES = [
'beginPageIndex',
'endPageIndex',
'pageIndex',
];
Loading
Loading