DataGrid - Fix the browser scrolling back to the grid when data is updated (T1310557)#33168
Open
markallenramirez wants to merge 10 commits intoDevExpress:26_1from
Open
DataGrid - Fix the browser scrolling back to the grid when data is updated (T1310557)#33168markallenramirez wants to merge 10 commits intoDevExpress:26_1from
markallenramirez wants to merge 10 commits intoDevExpress:26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes DataGrid keyboard-navigation focus restoration so that updating data doesn’t cause the browser to scroll the page back to the grid (by using native focus({ preventScroll }) during render completion).
Changes:
- Add a
preventScrollflag to_updateFocusand_focusand propagate it fromrenderCompleted. - Replace synthetic
eventsEngine.trigger(..., 'focus')with native DOMfocus({ preventScroll })for the focused cell/row.
packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/m_keyboard_navigation.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/m_keyboard_navigation.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/m_keyboard_navigation.ts
Outdated
Show resolved
Hide resolved
markallenramirez
force-pushed
the
bug_T1310557/26_1
branch
from
a9afe9f to
d2b9704
Compare
packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/scrollable_a11y.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/m_keyboard_navigation.ts
Outdated
Show resolved
Hide resolved
markallenramirez
force-pushed
the
bug_T1310557/26_1
branch
from
9ff69ab to
8b4814d
Compare
packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/m_keyboard_navigation.ts
Show resolved
Hide resolved
markallenramirez
force-pushed
the
bug_T1310557/26_1
branch
from
4080b45 to
6d35176
Compare
packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/focus.integration.tests.js
Outdated
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/focus.integration.tests.js
Outdated
Show resolved
Hide resolved
This reverts commit 8b4814d.
markallenramirez
force-pushed
the
bug_T1310557/26_1
branch
from
ecf7496 to
36c670d
Compare
packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/focus.integration.tests.js
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.