Repository navigation
Conversation
Signed-off-by: Pcristin <xxxokzxxx@protonmail.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
2 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed in favor of the earlier #2827, which contains the identical production fix. Additional regression coverage and completed validation results were shared there.
Fixes #2818.
Initialize the PlantUML operand ID before any early return, preventing empty or unterminated operands from reaching callers as an uninitialized slice. Two regression tests cover the three reported edge messages and 16 unterminated operand cases, including include-token retention and preservation of subsequent valid content.
Final local validation on Linux x86_64, Clang 20.1.2:
scripts/test.shentry exited 0: 10,025 passed, 0 failed, 10 Windows-only skips across all 191 suites, plus all enabled production guards. All 164 incremental tests ran.Limits remain explicit in the linked report: UBSan warnings in unchanged Perl/signature/RST code, existing full-tree tidy findings (manual sweep stopped at 40/242), one partial upstream Markdown parse, and an initial unchanged selector-fixture SIGPIPE followed by a successful full retry. CI was not wholly green: its UI dependency installation timed out, and the account lacks repository-admin permission to retry that job.
Written with Codex on behalf of Pcristin.