Skip to content

flake_regressions: Combine globs into fewer, longer jobs - #735

Merged
edolstra merged 1 commit into
mainfrom
flake-regressions-fewer-jobs
Oct 26, 2026
Merged

edolstra merged 1 commit into
mainfrom
flake-regressions-fewer-jobs

Conversation

@edolstra

@edolstra edolstra commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

The flake regression jobs vary between ~1 and ~12 minutes (e.g. https://github.com/DeterminateSystems/nix-src/actions/runs/40242643720), so we have many short jobs that mostly spend their time on setup, or worse, waiting for an available runner.

Implementation

Regroup the globs into 6 ranges that each take roughly 10 minutes, based on test step durations from the last 5 merge queue runs. This reduces the number of jobs from 42 to 18.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the regression test grouping in the build workflow from fourteen groups to six. The existing Nix configuration test entries are unchanged.

The per-glob jobs varied between ~1 and ~12 minutes. Based on the
"Run flake regression tests" step durations of the last 5 merge queue
runs, regroup the globs into 6 ranges that each take roughly 10
minutes in the slowest configuration (plus ~1 minute of job setup).
This reduces the number of jobs from 42 to 18.

Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
@edolstra edolstra added the flake-regression-test Run the flake regressions test suite on this PR label Oct 26, 2026
@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 27fea9a7-ce52-4b90-acd8-303474f2e1ce
Commits

Reviewing files that changed from the base of the PR and between 240bbbc and 21e3d7e.

Files selected for processing: 1
  • .github/workflows/build.yml

Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.

Walkthrough

The flake_regressions workflow matrix now uses six broader glob groups instead of fourteen. The comment states that each group takes roughly 10 minutes. The existing nix_config matrix entries remain unchanged.

Changes: Regression test matrix

Layer / File(s) Summary
Regression-test matrix groups
.github/workflows/build.yml
The matrix now uses six broader glob groups instead of fourteen. The comment states that each group takes roughly 10 minutes.

Priority: Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Possibly related PRs

  • DeterminateSystems/nix-src#728: It aggregates statistics artifacts from flake_regressions matrix jobs, so its aggregation must account for the revised matrix.

Suggested reviewers: cole-h

Merge Risk: Minimal · up to 21e3d

The workflow matrix change is mergeable with no identified correctness or availability risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: combining flake regression globs into fewer, longer jobs.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

@github-actions
github-actions Bot temporarily deployed to pull request October 26, 2026 11:08 Inactive
@edolstra
edolstra added this pull request to the merge queue Oct 26, 2026
Merged via the queue into main with commit ac71382 Oct 26, 2026
56 checks passed
@edolstra
edolstra deleted the flake-regressions-fewer-jobs branch October 26, 2026 16:48

This branch was previously deployed

1 inactive deployment
pull request — 21e3d7ec Deployed Oct 26, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flake-regression-test Run the flake regressions test suite on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants